Fix some javadocs. #2349
Merged
Fix some javadocs. #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
martinvw
approved these changes
Jun 9, 2017
holmes
added a commit
to holmes/openhab2-addons
that referenced
this pull request
Jun 16, 2017
* master: [senseBox] Forgot to add binding to feature.xml (openhab#2371) [Kodi] Fix audio sink (openhab#2301) (openhab#2303) Initial contribution of a Niko Home Control binding. (openhab#1589) [keba] fixed typo (openhab#2370) Removed utilisation of org.apache.http.client (openhab#2369) [RFXCOM] Make LWRF mood buttons work (openhab#2366) [senseBox] Switch caching to ESH ExpiringCacheMap (openhab#2361) Fixed problems found by AuthorTagCheck in the cometvisu bundle (openhab#2364) Added author tag where missing. (openhab#2351) [RFXCOM] Fix chill temperature (openhab#2362) initial contribution Windcentrale binding (openhab#1535) Tesla : reset the Even Stream connection to the Tesla Back-end if the event time stamps differ too much from the current system time (openhab#2358) Homematic: Some updates (openhab#2346) [RFXCOM] Support all data from wind sensors (openhab#2329) Gardena: Optimized refresh after command (openhab#2353) Fix some javadocs. (openhab#2349) Some small non-standard copyright banners which we missed while reviewing (openhab#2347)
falkena
pushed a commit
to falkena/openhab-addons
that referenced
this pull request
Jun 29, 2017
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
qvistgaard
pushed a commit
to qvistgaard/openhab2-addons
that referenced
this pull request
Jun 30, 2017
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
reyem
pushed a commit
to reyem/openhab2-addons
that referenced
this pull request
Jul 1, 2017
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
Markinus
pushed a commit
to Markinus/openhab2-addons
that referenced
this pull request
Jul 2, 2017
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
ppieczul
pushed a commit
to ppieczul/openhab2-addons
that referenced
this pull request
Jul 2, 2017
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
aogorek
pushed a commit
to aogorek/openhab2-addons
that referenced
this pull request
Jul 5, 2017
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
Markinus
pushed a commit
to Markinus/openhab2-addons
that referenced
this pull request
Sep 8, 2017
Includes: - some multi line comments changed to javadoc - some javadocs moved to the correct place See: #openhab/static-code-analysis/52 Signed-off-by: Svilen Valkanov <[email protected]>
Flole998
pushed a commit
to Flole998/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Display raw item state when formatting fails With the addition of Profiles, there are situations where a Channel sends format information that does not match the type. For example, "Timestamp on update" always sends a DateTime, but the channel may specify a different format (e.g., if it is a battery level, "%.0f %%"). In such a case, we attempt to format the DateTime according to the pattern, it (predictably and correctly) fails, and this results in an error in the UI and a warning in the log. While this is an expected error if a user uses an incorrect format code in an Item's metadata (user error), it is somewhat unexpected if a user is choosing an option as presented in the UI. Because this is purely a formatting issue, one solution is to direct users to add a formatting code if they see an error. However, the disadvantage of this approach is that it doesn't work "out of the box." This patch attempts to address the issue by displaying the raw Item state when formatting fails instead of displaying "Err". This should provide a more balanced approach with a predictable outcome. In addition, when a user is intentionally changing the pattern via metadata and gets it wrong, they should still see info in the log that helps them get to the root of the problem, but I've changed it from warn to info so it will be a little less noisy for those who choose to ignore it. This solution was discussed in openhab/openhab-core#2037 and https://community.openhab.org/t/timestamps-not-rendering-consistently-in-ui-3-0-2/121891/2 Thank you to @Rossko57 and @cweitkamp for their help in figuring it out, and in suggesting the solution. Signed-off-by: Brian Warner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
See: openhab/static-code-analysis#52
Signed-off-by: Svilen Valkanov [email protected]