[RFXCOM] Support all data from wind sensors #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes #2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
|
@mjagdis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @paulianttila, @martinvw and @kaikreuzer to be potential reviewers. |
martinvw
reviewed
Jun 3, 2017
There was a problem hiding this comment.
Looks good, one small issue and please also update the readme or add it as a note to https://github.com/openhab/openhab2-addons/pull/2327, I'm busy at it anyway.
| @@ -15,8 +15,19 @@ | |||
| <description>A Wind device.</description> | |||
|
|
|||
| <channels> | |||
| <channel id="windSpeed" typeId="windspeed" /> | |||
| <channel id="avgWindSpeed" typeId="windspeed" /> | |||
There was a problem hiding this comment.
I have an XML parsing error, here, it should not be self-closing I think
| @@ -72,8 +73,7 @@ | |||
| public static final String CHANNEL_RAIN_TOTAL = "rainTotal"; | |||
| public static final String CHANNEL_WIND_DIRECTION = "windDirection"; | |||
| public static final String CHANNEL_WIND_SPEED = "windSpeed"; | |||
| public static final String CHANNEL_GUST = "gust"; | |||
| public static final String CHANNEL_CHILL_FACTOR = "chillFactor"; | |||
There was a problem hiding this comment.
Were these already unused and not defined somewhere else, where they also should be removed?
There was a problem hiding this comment.
They were unused. Previously the gust value was what was being returned as windSpeed so to avoid breaking existing "working" setups I elected to keep that and add averageWindSpeed.
| str += ", Battery level = " + batteryLevel; | ||
|
|
||
| return str; | ||
| return super.toString() |
Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
martinvw
reviewed
Jun 3, 2017
| @@ -68,6 +68,9 @@ public static SubType fromByte(int input) throws RFXComUnsupportedValueException | |||
| public int sensorId; | |||
| public double windDirection; | |||
| public double windSpeed; | |||
| public double avgWindSpeed; | |||
There was a problem hiding this comment.
Quite some changes, should you be added as an co-author?
|
Same question should we wait for the user to respond? Or do you think its safe to merge already? |
Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
|
Okay, the user confirmed, if we have the readme updated it can be merged :-) |
holmes
added a commit
to holmes/openhab2-addons
that referenced
this pull request
Jun 16, 2017
* master: [senseBox] Forgot to add binding to feature.xml (openhab#2371) [Kodi] Fix audio sink (openhab#2301) (openhab#2303) Initial contribution of a Niko Home Control binding. (openhab#1589) [keba] fixed typo (openhab#2370) Removed utilisation of org.apache.http.client (openhab#2369) [RFXCOM] Make LWRF mood buttons work (openhab#2366) [senseBox] Switch caching to ESH ExpiringCacheMap (openhab#2361) Fixed problems found by AuthorTagCheck in the cometvisu bundle (openhab#2364) Added author tag where missing. (openhab#2351) [RFXCOM] Fix chill temperature (openhab#2362) initial contribution Windcentrale binding (openhab#1535) Tesla : reset the Even Stream connection to the Tesla Back-end if the event time stamps differ too much from the current system time (openhab#2358) Homematic: Some updates (openhab#2346) [RFXCOM] Support all data from wind sensors (openhab#2329) Gardena: Optimized refresh after command (openhab#2353) Fix some javadocs. (openhab#2349) Some small non-standard copyright banners which we missed while reviewing (openhab#2347)
kaikreuzer
added
the
enhancement
falkena
pushed a commit
to falkena/openhab-addons
that referenced
this pull request
Jun 29, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
qvistgaard
pushed a commit
to qvistgaard/openhab2-addons
that referenced
this pull request
Jun 30, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
jsjames
pushed a commit
to jsjames/openhab-addons
that referenced
this pull request
Jul 1, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
reyem
pushed a commit
to reyem/openhab2-addons
that referenced
this pull request
Jul 1, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
Markinus
pushed a commit
to Markinus/openhab2-addons
that referenced
this pull request
Jul 2, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
ppieczul
pushed a commit
to ppieczul/openhab2-addons
that referenced
this pull request
Jul 2, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
reyem
pushed a commit
to reyem/openhab2-addons
that referenced
this pull request
Jul 3, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
aogorek
pushed a commit
to aogorek/openhab2-addons
that referenced
this pull request
Jul 5, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
martinvw
reviewed
Jul 27, 2017
| @@ -60,14 +61,17 @@ public static SubType fromByte(int input) throws RFXComUnsupportedValueException | |||
|
|
|||
| private static final List<RFXComValueSelector> SUPPORTED_INPUT_VALUE_SELECTORS = Arrays.asList( | |||
| RFXComValueSelector.SIGNAL_LEVEL, RFXComValueSelector.BATTERY_LEVEL, RFXComValueSelector.WIND_DIRECTION, | |||
| RFXComValueSelector.WIND_SPEED); | |||
| RFXComValueSelector.AVG_WIND_SPEED, RFXComValueSelector.WIND_SPEED); | |||
There was a problem hiding this comment.
How could both of us miss this 😉
The temperature fields were not added here.
See https://github.com/openhab/openhab2-addons/issues/2495#issuecomment-318463340
If you ( @mjagdis ) would have time to fix this that would be great, I have no opportunity because I m not near anything except for a tablet for at least one more week.
Markinus
pushed a commit
to Markinus/openhab2-addons
that referenced
this pull request
Sep 8, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
hillmanr
pushed a commit
to hillmanr/openhab2-addons-pollytts
that referenced
this pull request
Dec 6, 2017
Previous code only supported wind direction and wind speed (actually gust speed). Added support for average wind speed, temperature and chill temperature where available. Closes openhab#2267 Signed-off-by: Mike Jagdis <[email protected]> (github: mjagdis)
Flole998
pushed a commit
to Flole998/openhab-addons
that referenced
this pull request
Dec 30, 2021
Signed-off-by: Wouter Born <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code only supported wind direction and wind speed (actually
gust speed). Added support for average wind speed, temperature and chill
temperature where available.
Closes #2267
Signed-off-by: Mike Jagdis [email protected] (github: mjagdis)