initial contribution Windcentrale binding #1535

marcelrv · 2016-12-07T00:28:04Z

Signed-off-by: Marcel Verpaalen [email protected]

martinvw

Hello Marcel,

Great binding, I made some items with the HTTP binding to monitor my 'winddelen' . However I could not get real time data from this API I had to use a different API for that.

I used the following url for real-time data:
http://backend.windcentrale.nl/windcentrale/productie_1.txt

I did some small review of your code.

martinvw · 2016-12-30T20:09:53Z

addons/binding/org.openhab.binding.windcentrale/examples.txt

@@ -0,0 +1,124 @@
+


Does this still have a role in the binding or was it only for the development.

It is only as reference. It is not used in any way in the binding.
Main purpose for me is that when the windcentrale protocol/API is changing, I know the 'from' situation.

A nicer and more functional way to add such information would be if it was part of a unit test.

martinvw · 2016-12-30T20:11:16Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindCentraleHandler.java

+
+        try {
+
+            //String getMillData = "{\"powerProducerId\":\"563fbecd-d6f8-4d5e-9c3a-5e8577c7e256\",\"windSpeed\":4.0,\"windDirection\":\"NW\",\"powerAbsTot\":141.0,\"powerAbsWd\":26.0,\"powerRel\":17.0,\"diameter\":29.0,\"rpm\":22.4,\"pulsating\":false,\"kwh\":1459683.0,\"kwhForecast\":2767000.0,\"hoursRunThisYear\":4606.0,\"runPercentage\":97.98130630630631,\"windSpeedForecast\":3.0,\"windDirectionForecast\":\"NW\",\"timestamp\":\"2016-07-14T11:30:08\"}";


Commented code

Indeed can be cleaned.
Thx

martinvw · 2016-12-30T20:12:38Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindCentraleHandler.java

+import org.eclipse.smarthome.core.types.RefreshType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+/*


Commented code

Indeed can be cleaned.
Thx

martinvw · 2016-12-30T20:13:11Z

...indcentrale/src/main/java/org/openhab/binding/windcentrale/WindCentraleBindingConstants.java

+    // List of all Channel IDs
+    public final static String CHANNEL_WIND_SPEED = "windSpeed";
+    public final static String CHANNEL_WIND_DIRECTION = "windDirection";
+    public final static String CHANNEL_POWER_TOTAL = "powerAbsTot";


Is there a reason you shortened this variable

Only to avoid very long names

martinvw · 2016-12-30T20:13:36Z

...indcentrale/src/main/java/org/openhab/binding/windcentrale/WindCentraleBindingConstants.java

+    public final static String CHANNEL_LAST_UPDATE = "timestamp";
+
+    public final static String PROPERTY_MILL_ID = "millId";
+    public final static String PROPERTY_WD = "wd";


Is there a reason you shortened this variable, do you refer to a windDelerId?

This is not the winddelerId. This is the number of owned winddelen... used to multiply the per winddeel power to the power assigned to you.

To help others to update the binding later on, it might be a better choice to not use uncommon abbreviations.

martinvw · 2016-12-30T20:15:11Z

addons/binding/org.openhab.binding.windcentrale/META-INF/MANIFEST.MF

@@ -0,0 +1,21 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: WindCentraler Binding


WindCentraler seems like a typo?

Indeed. Thx

martinvw · 2016-12-30T20:18:55Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+		</config-description>
+	</thing-type>
+
+	<channel-type id="windSpeedType">


I believe channel-type id's should be lower case, but I'm not sure.

I have not seen that being in the guidelines
e.g. https://www.eclipse.org/smarthome/documentation/development/bindings/thing-definition.html
has in the example a camelcase

Hmm, I will leave it up to @kaikreuzer maybe the discussion was specific to a binding.

Too bad there is no convention for this. Bindings now all differentiate between:

channelName

channelname

channel-name

The most common form I see used in bindings is camelCased.

Though I personally prefer lowercase. That's because I prefer the nicer looks with the lowercase binding ID and thing ID. It also saves key strokes with typing, because you do not constantly need a shift modifier. Also you do not have to think about what is upper and lower case. But this is still all personal preference.

martinvw · 2017-01-01T15:01:45Z

Can you add a downloaded jar, so others can download and test it?

marcelrv · 2017-01-03T11:46:18Z

I can send you a link where to download it. You can drop it in the addons folder. There is not an easy way build bindings can be distributed :( https://community.openhab.org/t/add-unvalidated-newbinding-to-the-oh2-addons-list/19301 2017-01-01 16:01 GMT+01:00 Martin van Wingerden <[email protected]>:

…

Can you add a downloaded jar, so others can download and test it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/openhab/openhab2-addons/pull/1535#issuecomment-269906183>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFmWbZZs7uX-K5mg2dkILy7JTDzCjbgQks5rN7_bgaJpZM4LGDkF> .

martinvw · 2017-01-03T12:16:40Z

Installing will not be the problem, I am/was just a little bit lazy to build it myself.

I believe you can even drop it in the comment field, then it will be hosted by Github

marcelrv · 2017-01-04T11:06:46Z

Please find it here

org.openhab.binding.windcentrale-2.0.0-SNAPSHOT.zip

martinvw · 2017-01-04T19:56:22Z

While linking all channel to there default new values, I get a clash between Vermogen en Energy Forecast (Also a mix of dutch and English)

martinvw · 2017-01-04T19:57:49Z

The same collision with "Productie vermogen (%)" and "Run percentage"

martinvw · 2017-01-04T20:07:39Z

The only thing which I have now with my custom setup and will lose with yours is today's production, I use it store yesterday productions and compare it with today production until now.

For the rest its great and it works!

marcelrv · 2017-01-08T11:09:10Z

While linking all channel to there default new values, I get a clash between Vermogen en Energy Forecast (Also a mix of dutch and English)
This is a strange one... the proper translation is in the file i18 file channel.windcentrale.kwhForecast.label = Verwachte Productie maybe this is a bug in the framework? as some labels come from the channel-type, others come from the channel?
What do you mean by clash? Do you see differences per screen? twice the same translation?

The same collision with "Productie vermogen (%)" and "Run percentage"
Here the translation was missing. Can you check if you see it now. (I've still to found how I can get the NL versions in the UI)

The total daily production is not in the feed indeed (think it also does not appear in the realtime URL you gave)
The only place I can see it is in the XML file (https://zep-api.windcentrale.nl/production/131?method=getProductie&molenid=131
), where you can also find the exact daily productions of the current month/year/day by hour etc.
As this needs only daily update, probably best to use http binding + XSLT transformation

marcelrv · 2017-01-08T11:19:21Z

latest

org.openhab.binding.windcentrale-2.0.0-SNAPSHOT.jar.zip

martinvw · 2017-01-15T08:03:43Z

Sorry for my slow response.

I think I spotted the problem with the labels

The translation file contains two times the text "Productie Vermogen (%)" 'powerAbsTot' vs 'powerRelType'
A translation label is missing for 'powerType', 'timestampType', 'windSpeed', 'windDirection', 'powerRel', 'kwh', 'timestamp'
In the thing file some items contain a sub-element label while others do not, I don't whether this is intended.

martinvw · 2017-01-15T08:04:29Z

The problem with the daily production is that you also need to apply a certain factor, so it makes it non-trivial.

wborn · 2017-02-19T11:35:06Z

As a fellow winddeler I'll also be testing this binding @marcelrv. I already gave the code a quick look and wonder why often the "C" is capitalized in WindCentrale? It seems that Windcentrale themselves are very consequent in their branding by always writing Windcentrale.

See for instance their blog: https://www.windcentrale.nl/blog

marcelrv · 2017-02-19T12:29:55Z

@wborn I think you have a fair point here.
There was no particular reason for it besides the regular java camelcasing. I'll update it

wborn

@marcelrv I've now had a more thorough look at the code and added some comments where I see room for improvement. Nothing really major so good job! :-)

Now I'll be putting your code to work and see if I can use it to replace my existing HTTP Binding items.

wborn · 2017-02-19T15:46:01Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/binding/binding.xml

+	xsi:schemaLocation="http://eclipse.org/smarthome/schemas/binding/v1.0.0 http://eclipse.org/smarthome/schemas/binding-1.0.0.xsd">
+
+	<name>WindCentrale Binding</name>
+	<description>Binding for a WindCentrale windmills</description>


The "a" can be removed so it reads like "Binding for Windcentrale windmills"

wborn · 2017-02-19T15:47:11Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

@@ -0,0 +1,24 @@
+# binding
+binding.windcentrale.name = WindCentrale Binding
+binding.windcentrale.description = Binding voor WindCentrale reports.


"reports" is not Dutch, and if this were a direct translation from English it would read "Binding voor Windcentrale windmolens"

wborn · 2017-02-19T15:51:22Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

+
+# thing types
+thing-type.windcentrale.mill.label = WindCentrale WindMolen
+thing-type.config.windcentrale.mill.millId.label = Wind Molen


This file uses for the Dutch word "windmolen" the words "WindMolen" "Wind Molen". Windcentrale does not see it as some kind of branded word, and also just refers to a windmill as "windmolen".

wborn · 2017-02-19T15:53:01Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

+# thing types
+thing-type.windcentrale.mill.label = WindCentrale WindMolen
+thing-type.config.windcentrale.mill.millId.label = Wind Molen
+thing-type.config.windcentrale.mill.wd.label = Aantal Wind Delen


Windcentrale does use a branded word for wind shares. That's why they refer to them with a capital "W", i.e. "Winddelen"

wborn · 2017-02-19T15:53:25Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

+thing-type.windcentrale.mill.label = WindCentrale WindMolen
+thing-type.config.windcentrale.mill.millId.label = Wind Molen
+thing-type.config.windcentrale.mill.wd.label = Aantal Wind Delen
+thing-type.config.windcentrale.mill.wd.description = Aantal Wind delen in bezit


So this sentence should also use "Winddelen"

wborn · 2017-02-19T16:08:23Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindCentraleHandler.java

+
+        int pollingPeriod = 30;
+        param = getConfig().get(PROPERTY_REFRESH_INTERVAL);
+        if (param instanceof BigDecimal && param != null) {


When param is null it is no instanceof BigDecimal, so the null check is not necessary.

wborn · 2017-02-19T16:15:39Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

+channel.windcentrale.powerAbsTot.label = Productie Vermogen (%)
+channel.windcentrale.powerAbsWd.label = Vermogen van de winddelen
+channel.windcentrale.kwhForecast.label = Verwachte Productie
+channel.windcentrale.runPercentage.label = Molen Productie percentage


It would be better if the same capitalization style was used everywhere in the translations. So either:

each sentence starts with a capital and uses lowercase for the rest of the sentence (excl. branded words)

or

each word is capitalized

The same applies to the English translations.

wborn · 2017-02-19T16:18:32Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindCentraleHandler.java

+        String urlString = baseURL + millId + "/live?ignoreLoadingBar=true";
+        try {
+            URL url = new URL(urlString);
+            URLConnection connection = url.openConnection();


It would be better when any connections are explicitly closed in a finally block.

wborn · 2017-02-19T16:25:09Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+				<default>131</default>
+			</parameter>
+			<parameter name="wd" type="integer" required="false">
+				<label>Wind Parts</label>


"Wind Shares" might be a better translation of the Dutch "Winddelen".

wborn · 2017-02-19T16:25:59Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+			</parameter>
+			<parameter name="wd" type="integer" required="false">
+				<label>Wind Parts</label>
+				<description># of wind parts ("winddelen")</description>


But then this line would also need to be updated to read "wind shares"

wborn · 2017-02-19T19:46:55Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+		<item-type>Number</item-type>
+		<label>Power</label>
+		<category>Energy</category>
+		<state pattern="%.1f Wh" readOnly="true" />


Power (Watt) and Energy (Watt/hour) are two different things. If the consumed power of a LED light is 10W then after 1 hour it has consumed 10Wh of energy (or. 0.01kWh). The same goes for the windmill instead it produces instead of consumes. So when there is "Power" in the label I would expect a "W" or "kW" unit. The category might also be wrong. But ESH is not clear about this.

wborn · 2017-02-19T19:47:52Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+		<item-type>Number</item-type>
+		<label>Power</label>
+		<category>Energy</category>
+		<state pattern="%.1f kWh" readOnly="true" />


The unit is probably "kW", see remark about power and energy above.

wborn · 2017-02-19T19:58:17Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+				<label>Total Power</label>
+			</channel>
+			<channel id="powerAbsWd" typeId="powerType">
+				<label>WD Power</label>


Can you make this more clear for English users? E.g. something like "Wind share power"? The Dutch have a more describing label with "Vermogen van de winddelen" . But I can imagine the Dutch label does not fit in some UIs because of its length. :-)

wborn · 2017-02-19T19:59:57Z

addons/binding/org.openhab.binding.windcentrale/README.md

+```
+Group   gReiger "WindCentrale Reiger"   <wind>
+
+Number  ReigerWindSpeed         "Wind Snelheid[%1.0f Bf]"         <wind>    (gReiger) {channel="windcentrale:mill:reiger:windSpeed")


All the documentation is in English. So using English labels would be better.

I would doubt any non-Dutch would ever use this binding, hence I kept this in Dutch, so it can be easy pasted in any item file.

wborn · 2017-02-19T20:20:03Z

Besides all my minor comments the binding does work well @marcelrv! So this will be a good replacement for the HTTP Binding items I've been using.

marcelrv · 2017-02-19T22:47:16Z

@wborn thanks for your good input.
Think I fixed them all

org.openhab.binding.windcentrale_2.1.0.201702192344.zip

wborn

Thanks for reworking the code so quickly @marcelrv! I've gone through all files again and added some minor remaining remarks.

wborn · 2017-02-20T18:06:12Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

@@ -0,0 +1,23 @@
+# binding
+binding.windcentrale.name = Windcentrale Binding
+binding.windcentrale.description = Binding voor Windcentrale windmolens.


It is a bit illogical that this translation does end with a "." whereas the other Dutch and English translations do not.

wborn · 2017-02-20T18:06:20Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

+thing-type.config.windcentrale.mill.wd.label = Aantal Winddelen
+thing-type.config.windcentrale.mill.wd.description = Aantal Winddelen in bezit
+thing-type.config.windcentrale.mill.refreshInterval.label = Ververs interval
+thing-type.config.windcentrale.mill.refreshInterval.description = Ververs interval in seconden.


It is a bit illogical that this translation does end with a "." whereas the other Dutch and English translations do not.

wborn · 2017-02-20T18:06:50Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/i18n/windcentrale_nl.properties

+thing-type.config.windcentrale.mill.refreshInterval.description = Ververs interval in seconden.
+
+# channels
+channel.windcentrale.windSpeed.label = Windsnelheid (Bf)


The abbreviation for Beaufort seems to be "Bft".

wborn · 2017-02-20T18:15:06Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+	xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0 http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd">
+
+	<thing-type id="mill">
+		<label>Windcentrale Wind Mill</label>


In English they refer to a "windmolen" as "windmill", i.e. without the space. There are many other occurrences in the code/XML that refer to "Wind Mill" or "Wind Mills".

Can you also give the English labels/descriptions the same capitalization treatment as you did with the Dutch ones? The Dutch ones look fine now. The English labels/descriptions now use a different capitalization strategy (first letter of each word capitalized) compared to the Dutch ones (first letter of sentence capitalized).

wborn · 2017-02-20T18:15:58Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+			</parameter>
+			<parameter name="wd" type="integer" required="false">
+				<label>Wind Shares</label>
+				<description># of wind shares ("Winddelen")</description>


Replacing "#" with "Number" would be better. It is already done so in the Dutch translations.

wborn · 2017-02-20T18:26:19Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindcentraleHandler.java

+        }
+
+        updateProperty(Thing.PROPERTY_VENDOR, "Windcentrale");
+        updateProperty(Thing.PROPERTY_MODEL_ID, "WindMolen");


It would make sense to replace this "M" with a "m" now that all other occurrences are written in lower case.

wborn · 2017-02-20T18:27:18Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindcentraleHandler.java

+    }
+
+    private synchronized void updateData() {
+        logger.debug("Update WindMolen data '{}'", getThing().getUID());


All the binding logging is in English, except for this "WindMolen".

wborn · 2017-02-20T18:28:44Z

...indcentrale/src/main/java/org/openhab/binding/windcentrale/WindcentraleBindingConstants.java

+import org.eclipse.smarthome.core.thing.ThingTypeUID;
+
+/**
+ * The {@link windcentraleBinding} class defines common constants, which are


{@link windcentraleBinding} should be {@link WindcentraleBindingConstants}.

wborn · 2017-02-20T18:41:34Z

addons/binding/org.openhab.binding.windcentrale/ESH-INF/thing/millThing.xml

+	<channel-type id="timestamp">
+		<item-type>DateTime</item-type>
+		<label>Last Updated</label>
+		<category>Date</category>


There is no "Date" category according to: https://eclipse.org/smarthome/documentation/development/bindings/thing-definition.html

wborn · 2017-02-20T18:43:57Z

addons/binding/org.openhab.binding.windcentrale/README.md

+
+
+## Full example
+```


Please add a new line after the header. See: https://eclipse.org/smarthome/documentation/development/bindings/docs.html

wborn · 2017-02-22T23:40:06Z

addons/binding/org.openhab.binding.windcentrale/META-INF/MANIFEST.MF

+Service-Component: OSGI-INF/*
+Export-Package: org.openhab.binding.windcentrale,
+ org.openhab.binding.windcentrale.handler
+Require-Bundle: org.apache.commons.io


The manifest must not contain any “Require-Bundle” entries. Instead, “Import-Package” must be used.

wborn

LGTM now Marcel

martinvw · 2017-05-30T09:02:27Z

You can then squash the commits of me & @wborn in to an also-by

Binding for windcentrale incl code reviews & updates Also-by: Wouter Born <[email protected]> Also-by: Martin van Wingerden <[email protected]> Signed-off-by: Marcel Verpaalen <[email protected]>

kaikreuzer

Thanks - a great service, which I would like to have in Germany as well!

Nice code and pretty straight-forward - I only have a few last comments.

kaikreuzer · 2017-06-06T13:45:02Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindcentraleHandler.java

+            logger.debug("Refreshing {}", channelUID);
+            updateData();
+        } else {
+            logger.warn("This binding is a read-only binding and cannot handle commands");


please reduce to debug and thus simply ignore commands

kaikreuzer · 2017-06-06T13:49:29Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindcentraleHandler.java

+
+        try {
+            String getMillData = getMillData();
+            JsonParser parser = new JsonParser();


Do you really need to create a new instance on every update? f not, it would be much better to keep this as a field in your class.

nope, improved it.

kaikreuzer · 2017-06-06T13:51:05Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindcentraleHandler.java

+    public void handleCommand(ChannelUID channelUID, Command command) {
+        if (command == RefreshType.REFRESH) {
+            logger.debug("Refreshing {}", channelUID);
+            updateData();


You might receive a REFRESH command for all channels sequentially - this could result in many concurrent ( and blocking) HTTP calls. You might be interested in this feature.

Thanks, implemented this new cache mechanism.

kaikreuzer · 2017-06-06T14:07:39Z

...windcentrale/src/main/java/org/openhab/binding/windcentrale/handler/WindcentraleHandler.java

+    }
+
+    private String getMillData() throws IOException {
+        try (InputStream connection = millUrl.openStream()) {


URLConnection is not really advised as it is sometimes a bit difficult to manage regarding error handling and proxy support. I'd suggest to go for HttpUtil.executeUrl() instead, which ESH provides and encapsulates all code using the Jetty HTTP client.

Indeed. Simplifies & improves. Done

Signed-off-by: Marcel Verpaalen <[email protected]>

kaikreuzer · 2017-06-11T20:40:43Z

Perfect, many thanks!

* master: [senseBox] Forgot to add binding to feature.xml (openhab#2371) [Kodi] Fix audio sink (openhab#2301) (openhab#2303) Initial contribution of a Niko Home Control binding. (openhab#1589) [keba] fixed typo (openhab#2370) Removed utilisation of org.apache.http.client (openhab#2369) [RFXCOM] Make LWRF mood buttons work (openhab#2366) [senseBox] Switch caching to ESH ExpiringCacheMap (openhab#2361) Fixed problems found by AuthorTagCheck in the cometvisu bundle (openhab#2364) Added author tag where missing. (openhab#2351) [RFXCOM] Fix chill temperature (openhab#2362) initial contribution Windcentrale binding (openhab#1535) Tesla : reset the Even Stream connection to the Tesla Back-end if the event time stamps differ too much from the current system time (openhab#2358) Homematic: Some updates (openhab#2346) [RFXCOM] Support all data from wind sensors (openhab#2329) Gardena: Optimized refresh after command (openhab#2353) Fix some javadocs. (openhab#2349) Some small non-standard copyright banners which we missed while reviewing (openhab#2347)

* WindCentrale binding Binding for windcentrale incl code reviews & updates Also-by: Wouter Born <[email protected]> Also-by: Martin van Wingerden <[email protected]> Signed-off-by: Marcel Verpaalen <[email protected]>

martinvw · 2017-09-26T12:47:24Z

@marcelrv could you remove the binding from the marketplace, I think it adds no value now its part of the build since release 2.1


		try {

		//String getMillData = "{\"powerProducerId\":\"563fbecd-d6f8-4d5e-9c3a-5e8577c7e256\",\"windSpeed\":4.0,\"windDirection\":\"NW\",\"powerAbsTot\":141.0,\"powerAbsWd\":26.0,\"powerRel\":17.0,\"diameter\":29.0,\"rpm\":22.4,\"pulsating\":false,\"kwh\":1459683.0,\"kwhForecast\":2767000.0,\"hoursRunThisYear\":4606.0,\"runPercentage\":97.98130630630631,\"windSpeedForecast\":3.0,\"windDirectionForecast\":\"NW\",\"timestamp\":\"2016-07-14T11:30:08\"}";

initial contribution Windcentrale binding #1535

initial contribution Windcentrale binding #1535

Conversation

marcelrv commented Dec 7, 2016

martinvw left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wborn Feb 19, 2017 • edited Loading

Choose a reason for hiding this comment

martinvw commented Jan 1, 2017

marcelrv commented Jan 3, 2017 via email

martinvw commented Jan 3, 2017

marcelrv commented Jan 4, 2017

martinvw commented Jan 4, 2017

martinvw commented Jan 4, 2017

martinvw commented Jan 4, 2017

marcelrv commented Jan 8, 2017

marcelrv commented Jan 8, 2017

martinvw commented Jan 15, 2017

martinvw commented Jan 15, 2017

wborn commented Feb 19, 2017

marcelrv commented Feb 19, 2017

wborn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wborn Feb 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wborn Feb 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wborn commented Feb 19, 2017

marcelrv commented Feb 19, 2017

wborn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wborn left a comment

Choose a reason for hiding this comment

martinvw commented May 30, 2017 • edited Loading

kaikreuzer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martinvw left a comment •

edited

Loading

wborn Feb 19, 2017 •

edited

Loading

wborn Feb 19, 2017 •

edited

Loading

wborn Feb 19, 2017 •

edited

Loading

martinvw commented May 30, 2017 •

edited

Loading

martinvw commented Sep 26, 2017 •

edited

Loading