[qbus] - Update logo / Small code changes #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Herbst <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
"format" parameter value for HTML seems that should be "html", not "HTML" "HTML" seems to have no affect when using sendPriorityMessage, but "html" works. Accepted without sign-off under minor change exemption. Signed-off-by: Koen Schockaert <[email protected]>
The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp. Accepted without sign-off under minor change exemption. Signed-off-by: Koen Schockaert <[email protected]>
* check device awake state and minor fixes * avoid update awake channel when not linked Signed-off-by: Miguel <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
#9985) * [hue] implement PR #2144 in openhab.core * [hue] add binding configuration parameter; return long Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…10023) * Retry command submission when tahome gateway is busy. * Changed log level, cosmetic changes * Store list of scheduled retries; cancelled when handler is disposed. * Made retryFutures thread-safe Signed-off-by: Georg Siebke <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Alexandr Salamatov <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Markus Storm <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Alexandr Salamatov <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
* Use system default channel types for lights Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…10134) Signed-off-by: Pauli Anttila <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
* #72 changed use units of measure for the twinguard humidity and purity values all other QuantityTypes in bindingcode are fine * #77 changed title of binding to Bosch Smart Home Replaced the SHC occurrences with Smart Home, to avoid technical names. * #62 Try to restart long polling when it fails before taking the thing offline * #62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request This might be the reason why the subscribe request does never finish or finishes with a timeout * #74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client * #74 Schedule initial access when long polling fails unexpected We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism. * Use direct formatting of logger.trace instead of String.format * #76 Use i18n texts instead of raw translations for status messages about failed long polling * #76 Use logger.debug instead of logger.warn for long poll error as it is handled now * #78 defined api-version each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller * logging bundle version removed the old static version string access OSGi bundle version information instead * #75 improved initial access - added isOnline check and isAccessPossible now failed in case HTTPStatus is an error - same HTTPStatus check done to all blocking send() request calls - using i18n strings for all bridge updateStatus calls - skipped the 'controller' and use only 'Bosch Smart Home' in descriptions - added more @nullable annotations * added newline Signed-off-by: Gerd Zanker <[email protected]> Signed-off-by: Christian Oeing <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Pauli Anttila <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…10137) * Removed internal vendor Map and minor additional improvements * Incorporated comments from review Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Fabian Wolter <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…10141) Signed-off-by: Koen Schockaert <[email protected]>
Extended the original collection with all the languages currently listed on the VoiceRSS API website. Please consider including in main branch. Signed-off-by: cURLy bOi <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…vered (#10099) Signed-off-by: Connor Petty <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…#10138) Fix #10055 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…ces (#10155) Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
…10148) * [bluetooth.bluegiga] Introduced better initialization functionality + other improvements * [bluetooth.bluegiga] Review change * [bluetooth.bluegiga] Fixed typo Signed-off-by: Pauli Anttila <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Ethan Dye <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
) Signed-off-by: Jan Philipp Giel <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
* add support for inverted to lock * run spotless Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
* [hdpowerview] refactor from jax-rs to http client * [hdpowerview] adopt proposals of code reviewer * [hdpowerview] adopt additional proposals of code reviewer * [hdpowerview] provide exception class name Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
* [bluetooth] Add BluetoothDevice.isNotifying() * [bluetooth] Improve Characteristic properties support * [bluez] Improve Characteristic properties support * [bluetooth] Add BluetoothDevice.canNotify() * [bluez] Also catch DBusExecutionException on read value * [bluetooth.generic] Activate notifications for linked channels where characteristics are able to notify * [bluez] Adjust javadoc * [bluegiga] Add BluetoothDevice.isNotifying() support * [bluegiga] Fix notification enabled check * [bluetooth] move canNotify() to Characteristic * [bluegiga] rename notificationEnabled to notifying * [bluetooth.generic] use handlerToChannels to subscribe to notifications * [bluetooth.generic] implement TODOs of canRead()/canWrite() * [bluetooth.generic] optimize ChannelUID * [bluetooth.generic] use channelUids for link check Signed-off-by: Peter Rosenberg <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Signed-off-by: Ethan Dye <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
Fixes #10114 Signed-off-by: Eiko Wagenknecht <[email protected]> Signed-off-by: Koen Schockaert <[email protected]>
fwolter
requested changes
Apr 19, 2021
|  | ||
|  |
There was a problem hiding this comment.
You can remove the logo here entirely as you uploaded it to the docs repo. The website will put the logo here automatically.
There was a problem hiding this comment.
ok, done. Took a look at other bindings and noticed there was no doc folder. So i removed mine as well. Hope this is ok?
Signed-off-by: Koen Schockaert <[email protected]>
|
Removed logo... |
Signed-off-by: Koen Schockaert <[email protected]>
|
@fwolter ok, i was confused and acted to quickly. Removed the logo completely now. |
|
@fwolter Can this be merged then? The website build is currently broken, which means we cannot publish the 3.0.2 release on our download page... |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Signed-off-by: Koen Schockaert <[email protected]> Signed-off-by: John Marshall <[email protected]>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Koen Schockaert <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
Signed-off-by: Koen Schockaert <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Koen Schockaert <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Koen Schockaert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logo.
I've updated the logo as mentioned by @Confectrician in #9191
Signed off by: Koen Schockaert [email protected]