Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] add support for flag "inverted" to lock accessory #10169

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Feb 16, 2021

add support for flag "inverted" to the lock accessory to swap the mapping to Switch.ON/OFF as requested here
https://community.openhab.org/t/openhab-3-0-1-invert-locks-homekit/117093/5

Signed-off-by: Eugen Freiter [email protected]

Signed-off-by: Eugen Freiter <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-0-1-invert-locks-homekit/117093/7

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

Looks like you need to run spotless.

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Feb 16, 2021
Signed-off-by: Eugen Freiter <[email protected]>
@yfre
Copy link
Contributor Author

yfre commented Feb 16, 2021

Looks like you need to run spotless.

you are right. missed spotless.
fixed now.

@cpmeister cpmeister merged commit e828bac into openhab:main Feb 16, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 16, 2021
K4ntir4n pushed a commit to K4ntir4n/openhab-addons that referenced this pull request Feb 17, 2021
…10169)

* add support for inverted to lock
* run spotless

Signed-off-by: Eugen Freiter <[email protected]>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…10169)

* add support for inverted to lock
* run spotless

Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: John Marshall <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…10169)

* add support for inverted to lock
* run spotless

Signed-off-by: Eugen Freiter <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…10169)

* add support for inverted to lock
* run spotless

Signed-off-by: Eugen Freiter <[email protected]>
@yfre yfre deleted the add_inverted_to_lock branch November 15, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants