[hue] Removed internal vendor Map and minor additional improvements #10137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <[email protected]>
cweitkamp
added
the
enhancement
lolodomo
reviewed
Feb 13, 2021
| @@ -123,6 +127,15 @@ private void initializeThing(@Nullable ThingStatus bridgeStatus) { | |||
| } | |||
| } | |||
|
|
|||
| private synchronized void initializeProperties(@Nullable FullGroup fullGroup) { | |||
| if (!propertiesInitializedSuccessfully && fullGroup != null) { | |||
There was a problem hiding this comment.
The members of a group can be changed (form the Hue app). In this case, the property will not be updated.
What is exactly the purpose of this new property in openHAB ?
There was a problem hiding this comment.
You are right. We do not need this flag. The framework checks for changes.
The property itself shows which members are part of the group.
Signed-off-by: Christoph Weitkamp <[email protected]>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…penhab#10137) * Removed internal vendor Map and minor additional improvements * Incorporated comments from review Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: John Marshall <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…penhab#10137) * Removed internal vendor Map and minor additional improvements * Incorporated comments from review Signed-off-by: Christoph Weitkamp <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…penhab#10137) * Removed internal vendor Map and minor additional improvements * Incorporated comments from review Signed-off-by: Christoph Weitkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp [email protected]