[bluetooth.generic] Enable BLE notification for linked channels #10122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
…characteristics are able to notify Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
Hilbrand
added
the
enhancement
cpmeister
requested changes
Feb 14, 2021
...h.bluegiga/src/main/java/org/openhab/binding/bluetooth/bluegiga/BlueGigaBluetoothDevice.java
Outdated
Show resolved
Hide resolved
...g.openhab.binding.bluetooth/src/main/java/org/openhab/binding/bluetooth/BluetoothDevice.java
Outdated
Show resolved
Hide resolved
...ic/src/main/java/org/openhab/binding/bluetooth/generic/internal/GenericBluetoothHandler.java
Outdated
Show resolved
Hide resolved
cpmeister
changed the title
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
cpmeister
requested changes
Feb 14, 2021
...ic/src/main/java/org/openhab/binding/bluetooth/generic/internal/GenericBluetoothHandler.java
Show resolved
Hide resolved
Signed-off-by: Peter Rosenberg <[email protected]>
cpmeister
requested changes
Feb 15, 2021
There was a problem hiding this comment.
Also can you please update the canRead and canWrite methods to check the characteristic property flags? Since you are adding support for the properties you should complete those TODOs as well.
Once that is done I think this is ready to merge. Thanks for all your work.
...ic/src/main/java/org/openhab/binding/bluetooth/generic/internal/GenericBluetoothHandler.java
Outdated
Show resolved
Hide resolved
...ic/src/main/java/org/openhab/binding/bluetooth/generic/internal/GenericBluetoothHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Rosenberg <[email protected]>
Signed-off-by: Peter Rosenberg <[email protected]>
|
You're welcome, thank you for your review. |
Signed-off-by: Peter Rosenberg <[email protected]>
cpmeister
approved these changes
Feb 16, 2021
K4ntir4n
pushed a commit
to K4ntir4n/openhab-addons
that referenced
this pull request
Feb 17, 2021
…hab#10122) * [bluetooth] Add BluetoothDevice.isNotifying() * [bluetooth] Improve Characteristic properties support * [bluez] Improve Characteristic properties support * [bluetooth] Add BluetoothDevice.canNotify() * [bluez] Also catch DBusExecutionException on read value * [bluetooth.generic] Activate notifications for linked channels where characteristics are able to notify * [bluez] Adjust javadoc * [bluegiga] Add BluetoothDevice.isNotifying() support * [bluegiga] Fix notification enabled check * [bluetooth] move canNotify() to Characteristic * [bluegiga] rename notificationEnabled to notifying * [bluetooth.generic] use handlerToChannels to subscribe to notifications * [bluetooth.generic] implement TODOs of canRead()/canWrite() * [bluetooth.generic] optimize ChannelUID * [bluetooth.generic] use channelUids for link check Signed-off-by: Peter Rosenberg <[email protected]>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…hab#10122) * [bluetooth] Add BluetoothDevice.isNotifying() * [bluetooth] Improve Characteristic properties support * [bluez] Improve Characteristic properties support * [bluetooth] Add BluetoothDevice.canNotify() * [bluez] Also catch DBusExecutionException on read value * [bluetooth.generic] Activate notifications for linked channels where characteristics are able to notify * [bluez] Adjust javadoc * [bluegiga] Add BluetoothDevice.isNotifying() support * [bluegiga] Fix notification enabled check * [bluetooth] move canNotify() to Characteristic * [bluegiga] rename notificationEnabled to notifying * [bluetooth.generic] use handlerToChannels to subscribe to notifications * [bluetooth.generic] implement TODOs of canRead()/canWrite() * [bluetooth.generic] optimize ChannelUID * [bluetooth.generic] use channelUids for link check Signed-off-by: Peter Rosenberg <[email protected]> Signed-off-by: John Marshall <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…hab#10122) * [bluetooth] Add BluetoothDevice.isNotifying() * [bluetooth] Improve Characteristic properties support * [bluez] Improve Characteristic properties support * [bluetooth] Add BluetoothDevice.canNotify() * [bluez] Also catch DBusExecutionException on read value * [bluetooth.generic] Activate notifications for linked channels where characteristics are able to notify * [bluez] Adjust javadoc * [bluegiga] Add BluetoothDevice.isNotifying() support * [bluegiga] Fix notification enabled check * [bluetooth] move canNotify() to Characteristic * [bluegiga] rename notificationEnabled to notifying * [bluetooth.generic] use handlerToChannels to subscribe to notifications * [bluetooth.generic] implement TODOs of canRead()/canWrite() * [bluetooth.generic] optimize ChannelUID * [bluetooth.generic] use channelUids for link check Signed-off-by: Peter Rosenberg <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…hab#10122) * [bluetooth] Add BluetoothDevice.isNotifying() * [bluetooth] Improve Characteristic properties support * [bluez] Improve Characteristic properties support * [bluetooth] Add BluetoothDevice.canNotify() * [bluez] Also catch DBusExecutionException on read value * [bluetooth.generic] Activate notifications for linked channels where characteristics are able to notify * [bluez] Adjust javadoc * [bluegiga] Add BluetoothDevice.isNotifying() support * [bluegiga] Fix notification enabled check * [bluetooth] move canNotify() to Characteristic * [bluegiga] rename notificationEnabled to notifying * [bluetooth.generic] use handlerToChannels to subscribe to notifications * [bluetooth.generic] implement TODOs of canRead()/canWrite() * [bluetooth.generic] optimize ChannelUID * [bluetooth.generic] use channelUids for link check Signed-off-by: Peter Rosenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluetooth low energy (BLE) allows central devices (like openHAB) to subscribe for changes. Whenever a subscribed value changes, the central devices is notified immediately so we don't need to wait until the value is polled next time.
Such a behaviour is useful for applications like push buttons or other devices where immediate action is required.
Changes
BluetoothCharacteristicto make them accessibleBluetoothDevice.canNotify()andBluetoothDevice.isNotifying()This is my first pull request to openHAB, feedback is very welcome.