-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] GH-9936 Fixed datatype for brightness of the ambient light #10065
Conversation
The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sign the commit, than the DCO check will be satisfied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…enhab#10065) The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp. Accepted without sign-off under minor change exemption. Signed-off-by: John Marshall <[email protected]>
…enhab#10065) The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp. Accepted without sign-off under minor change exemption.
…enhab#10065) The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp. Accepted without sign-off under minor change exemption.
The ceiling10 Yeelight lamp has 2 dimmer for brightness:
"bright" for the main light and bg_bright for the ambient light.
Both are of type dimmer and accept percentage values between 1 and 100.
This fix changes the datatype of the bg_bright property from Number
to Dimmer in the device mapping database file ceiling4, which is also
the one that is used for the ceiling10 lamp.