build: Release 4.45.0 #606

tshuli · 2020-11-10T02:17:47Z

New

feat: deprecate MYINFO_APP_KEY #557
feat: display a Toast when reCAPTCHA fails while users are filling up a form #582

Improvements

chore: set datepicker default view to minimum date #574
chore: shift webhook field to bottom of settings page, update copy #553
feat: move public spcp login form messaging #589
feat: remove exclamation when user updates contact #586
feat: update landing page footer #584
feat: use auth middleware to protect routes #568
refactor: convert MyInfo hash update to static domain method #562
refactor: hash uinFin in domain layer #596
refactor: migrate GET /adminform endpoint to Typescript #575
refactor: validate MyInfo env vars using Convict #559

Fixes

fix: overflow when printing responses #585

Dependencies

feat: upgrade myinfo-gov-client #593
fix(deps): bump @sentry/integrations from 5.25.0 to 5.27.3 #600
fix(deps): bump angular-cookies from 1.8.1 to 1.8.2 #590
chore(deps-dev): bump @babel/preset-env from 7.11.5 to 7.12.1 #599
chore(deps-dev): bump @types/node from 14.11.2 to 14.14.6 #588
chore(deps-dev): bump axios-mock-adapter from 1.18.2 to 1.19.0 #598
chore(deps-dev): bump eslint-plugin-import from 2.22.0 to 2.22.1 #580
chore(deps-dev): bump jasmine from 3.6.2 to 3.6.3 #587
chore(deps-dev): bump jest from 26.5.3 to 26.6.2 #570
chore(deps-dev): bump ngrok from 3.2.7 to 3.3.0 #578

)

Bumps [jest](https://github.com/facebook/jest) from 26.5.3 to 26.6.2. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v26.5.3...v26.6.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: merge release 4.44.0 into develop

Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.22.0 to 2.22.1. - [Release notes](https://github.com/benmosher/eslint-plugin-import/releases) - [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.22.0...v2.22.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [jasmine](https://github.com/jasmine/jasmine-npm) from 3.6.2 to 3.6.3. - [Release notes](https://github.com/jasmine/jasmine-npm/releases) - [Commits](jasmine/jasmine-npm@v3.6.2...v3.6.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [angular-cookies](https://github.com/angular/angular.js) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.1...v1.8.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ngrok](https://github.com/bubenshchykov/ngrok) from 3.2.7 to 3.3.0. - [Release notes](https://github.com/bubenshchykov/ngrok/releases) - [Commits](https://github.com/bubenshchykov/ngrok/commits/v3.3.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.11.2 to 14.14.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ref: move updateHashes hashing into model * test: update updateHashes tests * ref: add findHashes method * ref: use findHashes function * test: add tests for findHashes * test: update jasmine tests * ref: return only fields

* refactor: migrate extended express typing to vendor directory * feat(AuthMiddleware): add withUserAuthentication middleware * feat(ExampleRoutes): use withUserAuthentication middleware * test: remove 401 checks on controller tests As the authentication middleware is now on the router level and covered by integration tests * test(AuthMdw): add unit tests for withUserAuthenticated * refactor: replace auth.authenticateUser fn with withUserAuthentication * chore: trigger travis rebuild

* fix: overflow when printing responses * refactor: shift print style to core.css

* feat: move spcp gated form message to start page * feat: move MyInfo error to outside of form title * style: update styling of locked form message

… a form (#582)

* refactor: validate myinfo env vars using convict * refactor: combine imports * test: add required env vars to tests * ref: change myInfoClientMode default to prod

* refactor(FormModel): move types into form.types * feat(FormModel): add getDashboardForms static function * refactor: use form model static function to list dashboard forms * feat(AdminFormSvc): add getDashboardForms service function * feat(AdminFormCtl): add handler for GET /adminforms endpoint * refactor(AdminFormRoutes): use new handleListDashboardForms impl * test(AdminFormSvc): add tests for getDashboardForms * feat(FormModel): return lean object when retrieving dashboard forms * test(FormModel): add tests for getDashboardForms static fn * test: remove test cases for removed list form fn * test(AdminFormCtl): add tests * feat(AdminFormsRoutes): update list flow to use middleware * test(FormModel): add stronger test case to test return array

Bumps [axios-mock-adapter](https://github.com/ctimmerm/axios-mock-adapter) from 1.18.2 to 1.19.0. - [Release notes](https://github.com/ctimmerm/axios-mock-adapter/releases) - [Changelog](https://github.com/ctimmerm/axios-mock-adapter/blob/master/CHANGELOG.md) - [Commits](ctimmerm/axios-mock-adapter@v1.18.2...v1.19.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.11.5 to 7.12.1. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.1/packages/babel-preset-env) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 5.25.0 to 5.27.3. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@5.25.0...5.27.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: set datepicker default view to minimum date * refactor: set initDate only if minDate

* feat: add initial footer component * feat: replace current links with i18n translations social links are not replaced yet * feat: add social links to footer * feat: replace old footer with new footer component * style: remove border from second footer section * style: fix styling for ie11 move full color svg to file for better dimensions, update css * feat: update app name in landing footer from FormSG to Form

tshuli · 2020-11-10T02:25:51Z

@karrui

Tests

set datepicker default view to minimum date

Create date field. Set custom date range with minimum date in the distant past (e.g. 2015). Open the form in public view. Check that the datepicker opens to the month of the minimum date by default.
Create date field with no date validation. Open in public view. Check that the datepicker opens to the current month by default.
Check that date fields can be filled in and submitted successfully

tshuli · 2020-11-10T02:30:11Z

@tshuli

shift webhook field to bottom of settings page

Create storage mode form. Add any webhook url. Submit form. Check in the logs that attempt was made to post the response to webhook url.

move public spcp login form messaging

Create form with myinfo field. Test that the messaging shows up correctly in public view Note: for Myinfo error message, can use the faulty accounts in 1pw

remove exclamation when user updates contact

Log in and add emergency contact. Check that the exclamation disappears once the emergency contact has been added without need for page refresh.

update landing page footer

Check that landing page footer displays correctly

deprecate MYINFO_APP_KEY

Create form with ALL myinfo fields. Check that form can be filled in and submitted successfully.

tshuli · 2020-11-10T02:32:05Z

@karrui
overflow when printing responses

Create storage mode form. Add 10 short text fields. Submit. Open submitted response in response tab. Check that all responses are captured in print preview.

GIF:

tshuli · 2020-11-10T02:36:03Z

@karrui
Run through on IE / Intranet
General run through

Create email mode form with all fields. Activate and submit form. Check that you can receive responses in your GSIB inbox.
Collaborators can be added in email mode.
Create storage mode form with all fields. Activate and submit form.
Response CSV can be downloaded for storage mode.
Responses can be viewed in Data tab in storage mode.
Attachments can be downloaded from Data tab in storage mode.
Submission IDs can be filtered in storage mode.
Collaborators can be added and their collaborating rights edited in storage mode.
Create form with MyInfo fields. Submit successfully

tshuli · 2020-11-10T02:36:47Z

@mantariksh
Run through on IE / Intranet
Specific

overflow when printing responses

Create storage mode form. Add 10 short text fields. Submit. Open submitted response in response tab. Check that all responses are captured in print preview.

deprecate MYINFO_APP_KEY

Create form with ALL myinfo fields. Check that form can be filled in and submitted successfully.

set datepicker default view to minimum date

Create date field. Set custom date range with minimum date in the distant past (e.g. 2015). Open the form in public view. Check that the datepicker opens to the month of the minimum date by default.
Create date field with no date validation. Open in public view. Check that the datepicker opens to the current month by default.
Check that date fields can be filled in and submitted successfully

shift webhook field to bottom of settings page

Create storage mode form. Add any webhook url. Submit form. Check in the logs that attempt was made to post the response to webhook url.

move public spcp login form messaging

Create form with myinfo field. Test that the messaging shows up correctly in public view Note: for Myinfo error message, can use the faulty accounts in 1pw

remove exclamation when user updates contact

Log in and add emergency contact. Check that the exclamation disappears once the emergency contact has been added without need for page refresh.

update landing page footer

Check that landing page footer displays correctly

tshuli and others added 25 commits November 3, 2020 10:12

chore: shift webhook field to bottom of settings page, update copy (#553

b915b50

)

refactor: convert MyInfo hash update to static domain method (#562)

f3320bb

Merge pull request #581 from opengovsg/release-4.44.0

6fe6829

chore: merge release 4.44.0 into develop

feat: remove exclamation when user updates contact (#586)

34705fc

feat: deprecate MYINFO_APP_KEY (#557)

7c56797

feat: upgrade myinfo-gov-client (#593)

2905cbd

refactor: hash uinFin in domain layer (#596)

0e1ecee

* ref: move updateHashes hashing into model * test: update updateHashes tests * ref: add findHashes method * ref: use findHashes function * test: add tests for findHashes * test: update jasmine tests * ref: return only fields

fix: overflow when printing responses (#585)

b5f29be

* fix: overflow when printing responses * refactor: shift print style to core.css

feat: move public spcp login form messaging (#589)

fe75228

* feat: move spcp gated form message to start page * feat: move MyInfo error to outside of form title * style: update styling of locked form message

feat: display a Toast when reCAPTCHA fails while users are filling up…

0c3d778

… a form (#582)

refactor: validate MyInfo env vars using Convict (#559)

aaacd5b

* refactor: validate myinfo env vars using convict * refactor: combine imports * test: add required env vars to tests * ref: change myInfoClientMode default to prod

chore: set datepicker default view to minimum date (#574)

47509a0

* chore: set datepicker default view to minimum date * refactor: set initDate only if minDate

chore: bump version to 4.45.0

c8d3463

karrui approved these changes Nov 10, 2020

View reviewed changes

tshuli merged commit fcd8c09 into release Nov 10, 2020

liangyuanruo deleted the release-4.45.0 branch January 14, 2021 06:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Release 4.45.0 #606

build: Release 4.45.0 #606

tshuli commented Nov 10, 2020 •

edited

Loading

tshuli commented Nov 10, 2020 •

edited by karrui

Loading

tshuli commented Nov 10, 2020 •

edited

Loading

tshuli commented Nov 10, 2020 •

edited by karrui

Loading

tshuli commented Nov 10, 2020 •

edited

Loading

tshuli commented Nov 10, 2020 •

edited by mantariksh

Loading

build: Release 4.45.0 #606

build: Release 4.45.0 #606

Conversation

tshuli commented Nov 10, 2020 • edited Loading

tshuli commented Nov 10, 2020 • edited by karrui Loading

Tests

tshuli commented Nov 10, 2020 • edited Loading

tshuli commented Nov 10, 2020 • edited by karrui Loading

tshuli commented Nov 10, 2020 • edited Loading

tshuli commented Nov 10, 2020 • edited by mantariksh Loading

tshuli commented Nov 10, 2020 •

edited

Loading

tshuli commented Nov 10, 2020 •

edited by karrui

Loading

tshuli commented Nov 10, 2020 •

edited

Loading

tshuli commented Nov 10, 2020 •

edited by karrui

Loading

tshuli commented Nov 10, 2020 •

edited

Loading

tshuli commented Nov 10, 2020 •

edited by mantariksh

Loading