Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display a Toast when reCAPTCHA fails while users are filling up a form #582

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

jia1
Copy link
Member

@jia1 jia1 commented Nov 3, 2020

Problem

Closes #31

Solution

Display a Toast when the captcha module's on-error handler is fired.

Features:

  1. The Toast does not show up immediately upon page load. It takes a bit of time (5 seconds) to show up after a user first touches the form (e.g. clicking on a form field). User does not need to fill up anything. He/she just needs to touch the form.
  2. The Toast shows up at the same time as the reCAPTCHA failure at the bottom of the form (this is good).

Before & After Screenshots

BEFORE:
Only the reCAPTCHA failure at the bottom of the form will be observed after the user touches the form.

AFTER:
Both Toast at the top and reCAPTCHA failure at the bottom will be observed.

photo6134426425541896706

@jia1 jia1 requested a review from karrui November 3, 2020 10:08
@jia1 jia1 self-assigned this Nov 3, 2020
@jia1 jia1 added the contribute free for contributors to pick up label Nov 3, 2020
@karrui
Copy link
Contributor

karrui commented Nov 4, 2020

The error on your screenshot does not seem to be the error in your commit?

@jia1
Copy link
Member Author

jia1 commented Nov 5, 2020

@karrui my bad. I took that screenshot before updating the message to the correct one. I went to take the new screenshot and updated it here. Thanks for the catch!

@karrui
Copy link
Contributor

karrui commented Nov 6, 2020

@syan-syan is the copywriting good enough? Should we also prompt the user to refresh or? Or tell the user that submission will fail?

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! approve first, can always update wording later

@karrui karrui merged commit 0c3d778 into develop Nov 9, 2020
@karrui karrui deleted the feat/toast-when-recaptcha-fails branch November 9, 2020 03:34
@tshuli tshuli mentioned this pull request Nov 10, 2020
@r00dgirl
Copy link
Contributor

@karrui @jia1 sorry for some reason these notifs sometimes get filtered to junk. the copy is fine. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute free for contributors to pick up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform respondent immediately when form fails to connect to captcha
3 participants