feat: deprecate MYINFO_APP_KEY #557
Conversation
| } else if (config.isDev && process.env.MYINFO_APP_KEY) { | ||
| myInfoConfig.appId = 'STG2-' + myInfoConfig.singpassEserviceId | ||
| myInfoConfig.privateKey = process.env.MYINFO_APP_KEY | ||
| myInfoConfig.mode = 'stg' |
There was a problem hiding this comment.
do we no longer need a stg mode?
There was a problem hiding this comment.
we do, but it's set via the env var MYINFO_CLIENT_CONFIG, which is set to stg in our staging environment. MYINFO_APP_KEY is unused.
There was a problem hiding this comment.
will this break the development integration with mockpass?
There was a problem hiding this comment.
so if I'm not wrong, the purpose of this is to have a dev environment that talks to MyInfo dev instead of MyInfo mockpass? MyInfo has 4 different environments if I'm not wrong; Prod, staging, dev and mockpass. Am i correct @liangyuanruo ?
There was a problem hiding this comment.
I've tested myinfo on mockpass and it works fine. we don't use this env var in our dev environment, we only use MYINFO_CLIENT_CONFIG.
There was a problem hiding this comment.
isn't the purpose of this just so that you can specify a key directly in the env vars instead of specifying a file path? why would it be listed as "deprecated" in our documentation if it's required for something?
There was a problem hiding this comment.
@arshadali172 do you mean the myinfo-gov-client mode? that mode is specified using MYINFO_CLIENT_CONFIG
Problem
The environment variable
MYINFO_APP_KEYis still present in the code for our non-production environments, even though it is no longer used. It should be fully deprecated so that we can migrate the SPCP/MyInfo code to TypeScript without worrying about supporting it. Moreover, open-source users should be able to onboard MyInfo without being confused betweenMYINFO_APP_KEYandMYINFO_FORMSG_KEY_PATH.Solution
Deprecate
MYINFO_APP_KEYand remove it from the documentation.