Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: validate MyInfo env vars using Convict #559

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Nov 2, 2020

Problem

MyInfo environment variables are currently not being read and validated by Convict like all the others. Instead, they are read directly from process.env. This also means the spcp-myinfo feature is activated even when the MyInfo environment variables are missing.

Solution

Integrate the MyInfo environment variables into the existing Convict framework.

@mantariksh mantariksh force-pushed the refactor/myinfo-config branch 2 times, most recently from 1e04cd3 to 457955f Compare November 5, 2020 13:40
@mantariksh mantariksh force-pushed the refactor/myinfo-config branch from 39c0002 to 0bda3a7 Compare November 5, 2020 13:46
@mantariksh mantariksh marked this pull request as ready for review November 5, 2020 14:50
@mantariksh mantariksh merged commit aaacd5b into develop Nov 9, 2020
@mantariksh mantariksh deleted the refactor/myinfo-config branch November 10, 2020 01:51
@tshuli tshuli mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants