refactor: migrate MyInfo functionality to TypeScript #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
force-pushed
the
refactor/ts-myinfo
branch
4 times, most recently
from
c78d5f8 to
79a5c38
Compare
liangyuanruo
approved these changes
Nov 11, 2020
tshuli
reviewed
Nov 11, 2020
mantariksh
force-pushed
the
refactor/ts-myinfo
branch
2 times, most recently
from
d1bf584 to
1a6e9c6
Compare
|
waiting to finish writing tests + test on staging before merging |
|
unfortunately MyInfo staging is still down so we can't test this on staging yet. will give them a call later today |
mantariksh
force-pushed
the
refactor/ts-myinfo
branch
2 times, most recently
from
7295fb2 to
87599eb
Compare
|
myinfo staging still not working |
mantariksh
force-pushed
the
refactor/ts-myinfo
branch
from
87599eb to
50a4b13
Compare
* test: add constants * refactor: inline myinfo_hash tests * test: add utils tests * test: add MyInfoService tests * test: add factory tests
mantariksh
force-pushed
the
refactor/ts-myinfo
branch
from
50a4b13 to
0aa68dd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts MyInfo functionality from combined SPCP/MyInfo modules, and places it in its own service written in TypeScript.
Why a service and not a module?
I wrote this with the future PublicForm migration in mind. Currently, the two middlewares exported by the MyInfo controller (
addMyInfoandverifyMyInfoVals) are middlewares in the form retrieval and submissions flow respectively. However, we want the logic in all these middlewares to eventually be combined into one function which calls several services. The intention here is for MyInfo to be one of those services, and for the logic in the current MyInfo controller functions to be moved into the PublicForm controllers in future.What about tests?
I have removed the old tests so that this PR builds successfully. The new tests will come in a separate PR and will be merged into this branch.