ref: convert req.hashedFields to Set #617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
myinfo.server.controller
assigns ahashedFields
key to the Express request object in order for subsequent middlewares to keep track of which MyInfo attributes have been verified through their hashes.hashedFields
is an object which maps the MyInfo attribute to the corresponding client response, but subsequent middlewares have no need for the values of this object, since they only check that the value corresponding to each key is truthy, i.e. that the object contains the key.Solution
Convert
hashedFields
into a Set, which is the more correct data structure for this case. This ensures that subsequent refactors (#560) don't have to bend over backwards just to gethashedFields
into the right format.Also, assign
hashedFields
tores.locals
instead ofreq
.