Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overflow when printing responses #585

Merged
merged 2 commits into from
Nov 9, 2020
Merged

fix: overflow when printing responses #585

merged 2 commits into from
Nov 9, 2020

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Nov 4, 2020 •
edited
Loading

Problem

Closes #83

Solution

  • force allow overflow when printing

Before & After Screenshots

BEFORE:
(cut off after first page)

Screenshot 2020-11-04 at 11 50 29 AM

AFTER:

Screenshot 2020-11-04 at 11 49 53 AM

Tests

  • Create storage mode form. Add 10 short text fields. Submit. Open submitted response in response tab. Check that all responses are captured in print preview.

Tested on GSIB-IE

@tshuli tshuli marked this pull request as ready for review November 4, 2020 05:04
@tshuli tshuli force-pushed the fix-response-print branch from 6eccaa2 to 59f9832 Compare November 4, 2020 12:45
@tshuli tshuli requested a review from liangyuanruo November 4, 2020 12:46
@tshuli tshuli merged commit b5f29be into develop Nov 9, 2020
@tshuli tshuli deleted the fix-response-print branch November 9, 2020 03:00
@tshuli tshuli mentioned this pull request Nov 10, 2020
Merged
@tshuli tshuli mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

@liangyuanruo liangyuanruo Awaiting requested review from liangyuanruo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshuli @liangyuanruo @mantariksh