build: release v6.37.0

[wanlingt]

New

• fix: submit admin feedback form #5981
• fix: typo in readme #5979
• docs: improve contribution guidelines #5925
• fix: move permission list validation from model level to service layer #5946
• docs: Script to find invalid whitespaces #5945
• build: merge Release 6.36.1 back into develop #5941
• fix: trim dropdown options for logic check #5940
• test(e2e): add storage mode e2e tests #5926
• feat: otp prefix for respondents email and mobile fields #5874
• feat: update uen entity types #5915
• test(e2e/email): add form auth tests #5876
• build: merge v6.36.0 into develop #5914
• build: release v6.36.0 #5913
• chore: bump version to 6.36.1 faf75b5

Dependencies

• fix(deps): bump type-fest from 3.6.1 to 3.7.0 in /shared #5986
• fix(deps): bump libphonenumber-js from 1.10.15 to 1.10.24 #5943
• fix(deps): bump moment-timezone from 0.5.40 to 0.5.41 #5939
• fix(deps): bump libphonenumber-js from 1.10.21 to 1.10.24 in /shared #5936
• chore(deps): bump @opengovsg/myinfo-gov-client from 4.0.1 to 4.0.2 #5931

Dev-Dependencies

• chore(deps-dev): bump @typescript-eslint/eslint-plugin from 5.55.0 to 5.56.0 in /shared #5953
• chore(deps-dev): bump @typescript-eslint/parser from 5.52.0 to 5.56.0 #5978
• chore(deps-dev): bump eslint-config-prettier from 8.7.0 to 8.8.0 in /shared #5952
• chore(deps-dev): bump @typescript-eslint/parser from 5.55.0 to 5.56.0 in /shared #5954
• chore(deps-dev): bump csv-parse from 5.3.3 to 5.3.6 #5951
• chore(deps-dev): bump rimraf from 3.0.2 to 4.4.0 #5947
• chore(deps-dev): bump jest-localstorage-mock from 2.4.25 to 2.4.26 #5916
• chore(deps-dev): bump @typescript-eslint/eslint-plugin from 5.54.1 to 5.55.0 in /shared #5923
• chore(deps-dev): bump @typescript-eslint/parser from 5.54.1 to 5.55.0 in /shared #5922

Tests

fix: submit admin feedback form #5981

@LinHuiqing

• On an admin page, click the speech bubble icon on the bottom right of the screen. Submit your feedback (make sure that any text entered is longer than 5 characters)
• (To test that the public feedback form is also still working) Change REACT_MIGRATION_RESP_ROLLOUT_EMAIL to 99. Go to an email-mode public form and click the "switch back" banner at the bottom of the page. This should open a modal with long text field (and email field if not logged in as admin). Fill the form. It should submit successfully to the public feedback form.

fix: move permission list validation from model level to service layer #5946

@KenLSM

• Ensure that the email domain data.gov.sg is not in the govtech agency. Try to add [email protected] email as a collaborator. This should fail.
• Add the data.gov.sg email domain to the govtech agency. Now add [email protected] and [email protected] email as collaborators. Then, remove the data.gov.sg email domain from the govtech agency. Perform the following actions in order.
  • Try modifying some form fields. This should work.
  • Remove [email protected] as a collaborator. This should work.
  • Modify the read/write permission of [email protected]. This should fail.
  • Add [email protected] as a collaborator. This should work.
  • Remove [email protected] as a collaborator. This should work.

Notes

Separately, I found an existing bug with transfer ownership. We currently allow ownership to be transferred to users whose emails are no longer valid domains belonging to any agency. You can see this in the second video clip, right at the end. I'll open a ticket for it after looking through the existing issues to see if it's duplicated.

feat: otp prefix for respondents email and mobile fields #5874

@wanlingt

• OTP prefix should exist on FE on OTP enabled
  • email verification field
  • mobile number verification field
• OTP prefix should sent to user's
  • mobile device
  • email

feat: update uen entity types #5915

@tshuli

• newly added UEN should pass T23BN1234Y
• existing UEN should pass
  • type A nnnnnnnnX i.e., 12345678Y
  • type B yyyynnnnnX i.e., 202312345Y
  • type C TyyPQnnnnX i.e., T23LP1234Y
• sanity check of incorrect UEN should fail T23LP12345