docs: Script to find invalid whitespaces #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tshuli
commented
Mar 20, 2023
tshuli
commented
- Adds a reference script which was used for trailing whitespaces incident
- Reference hotfix: build: release 6.36.1 hotfix #5940
timotheeg
approved these changes
Mar 20, 2023
Comment on lines
+110
to
+111
| // TODO query submission to chedk how many forms of those forms had submissions in the past 3 weeks. | ||
|
|
There was a problem hiding this comment.
Can remove this TODO since it was done :)
Suggested change
| // TODO query submission to chedk how many forms of those forms had submissions in the past 3 weeks. |
timotheeg
approved these changes
Mar 21, 2023
timotheeg
reviewed
Mar 21, 2023
Comment on lines
+158
to
+174
| const allSubmissions = await submissionCollection | ||
| .find({ | ||
| created: { | ||
| $gte: new Date(START_DATE_TIME), | ||
| $lt: new Date(END_DATE_TIME), | ||
| }, | ||
| }) | ||
| .project({ _id: 1, form: 1 }) | ||
| .toArray() | ||
|
|
||
| console.log(allSubmissions.length) | ||
|
|
||
| console.log('-----') | ||
| console.log( | ||
| 'Total number of forms which received submissions during that timeframe:', | ||
| ) | ||
| const allForms = new Set(allSubmissions.map((s) => s.form.toString())) |
There was a problem hiding this comment.
This works fine, but just some feedback: the process as coded here gathers a huge dataset of repeated entries, that needs to be stored entirely in memory (~1.3M entries in this case).
When computing stats, leverage the DB as much as possible to reduce the size of datasets to just what you need. In this case, it would have probably been better to query for an aggregate of submission count by formid, and then do a summation of the submission counts in code to derive the total number of submissions received overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.