Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release 6.36.1 hotfix #5940

Merged
merged 3 commits into from
Mar 17, 2023
Merged

build: release 6.36.1 hotfix #5940

merged 3 commits into from
Mar 17, 2023

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Mar 17, 2023

Problem

  • In release 6.32.0, we introduced a bug fix to fix another issue where logic with trailing spaces was preventing submission.
  • This inadvertently led to another bug where logic conditions are not triggering if the dropdown condition contains whitespace
  • To resolve the bug, this PR trims the whitespace on dropdown options before running logic check.

Tests

  • Create form dropdown as show logic. In DB, add whitespace to both the dropdown option and logic option.
  • Show logic should still work when user selects the dropdown option with whitespace.
  • Test again if dropdown has no whitespace but logic has whitespace
  • Test again if dropdown has whitespace but logic has no whitespace

@tshuli tshuli force-pushed the release-6.36.1-hotfix branch from 7bc8b06 to faf75b5 Compare March 17, 2023 10:42
@tshuli tshuli temporarily deployed to staging-al2 March 17, 2023 10:42 — with GitHub Actions Inactive
Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tshuli tshuli changed the title fix: trim dropdown options for logic check build: release 6.36.1 hotfix Mar 17, 2023
@tshuli tshuli merged commit 75b6d31 into release-al2 Mar 17, 2023
@tshuli tshuli deleted the release-6.36.1-hotfix branch March 17, 2023 11:23
@wanlingt wanlingt mentioned this pull request Mar 24, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants