test(e2e/email): add form auth tests #5876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
force-pushed
the
chore/react-e2e-email-auth
branch
3 times, most recently
from
2e4862a to
6f7d17a
Compare
justynoh
force-pushed
the
chore/react-e2e-email-auth
branch
from
6f7d17a to
2ff6f18
Compare
justynoh
force-pushed
the
chore/react-e2e-email-auth
branch
from
2ff6f18 to
b527c99
Compare
…goes to 1 retry, return bogus error codes to see what's causing 400
justynoh
force-pushed
the
chore/react-e2e-email-auth
branch
18 times, most recently
from
3711d2d to
09bdd79
Compare
justynoh
force-pushed
the
chore/react-e2e-email-auth
branch
2 times, most recently
from
38334f4 to
eeb2863
Compare
…gus string for UIN
justynoh
force-pushed
the
chore/react-e2e-email-auth
branch
from
eeb2863 to
cce7761
Compare
KenLSM
reviewed
Mar 13, 2023
KenLSM
approved these changes
Mar 13, 2023
|
Also, if you're reading this, please know that all the force pushes are there because I was trying to debug tests that were working fine locally but not in CI. It turns out that mockpass used |
8 tasks
|
do we want to add this to branch protection rules? doing release now and I realise I don't have to wait for these tests to pass to merge into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we initially migrated e2e tests to Playwright, mockpass was not compatible with our OIDC version. Thus, we omitted e2e tests for forms with authentication. Since mockpass has been updated, form authentication has been restored locally, and therefore we should restore these tests.
Solution
Added tests for SP, CP, SGID and MyInfo. Small adjustment to be made for the myinfoable types in
field.ts.Had to upgrade node version for our CI to 18 to be compatible with mockpass.
Sorry about the lines changed metric, a large proportion of the changes made in
createFormis just a giant refactor (to account for auth-ing the form with mockpass).Separately, I got annoyed with having to type legacy-peer-deps every time so i added it to .npmrc and updated the README.