test(e2e): add storage mode e2e tests #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and reopening to get CI to run |
|
snyk pls 🥺 |
KenLSM
reviewed
Mar 16, 2023
| @@ -166,15 +166,15 @@ export const ALL_FIELDS: E2eFieldMetadata[] = [ | |||
| { | |||
| title: 'Birthday', | |||
| fieldType: BasicField.Date, | |||
| val: format(new Date(), DATE_INPUT_FORMAT), | |||
| val: format(new Date(952970366), DATE_INPUT_FORMAT), | |||
There was a problem hiding this comment.
Is this date value 952970366 special?
There was a problem hiding this comment.
ok no but on a serious note, I couldn't leave it as the current date because our Storage mode's individual response page also displays the date of submission which would also be the current date. So the expect() for finding the response to this question would certainly always succeed, regardless of whether the response to the question was shown.
KenLSM
reviewed
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't have e2e tests for storage mode yet! This PR adds them and achieves parity with Angular.
Closes #5113
Solution
Shard out some of the test case data that is shared between the two modes.
Add support for storage mode in all relevant handlers. Specifically, changes needed to be made to createForm and verifySubmission to accommodate storage mode individual response page and CSV modes which each displayed data differently (help...). Some utils had to be modified as well in the process.