Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release 5.16.0 #2229

Merged
merged 34 commits into from
Jun 22, 2021
Merged

build: release 5.16.0 #2229

merged 34 commits into from
Jun 22, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Jun 22, 2021

NEW

IMPROVED 

FIXES

  • test: fix flaky form feedback test #2217

DEPENDENCY UPDATES

  • chore(deps-dev): bump @babel/core from 7.14.5 to 7.14.6 #2185
  • chore(deps-dev): bump @opengovsg/mockpass from 2.7.3 to 2.7.4 #2192
  • chore(deps-dev): bump eslint from 7.28.0 to 7.29.0 #2216
  • chore(deps-dev): bump type-fest from 1.2.0 to 1.2.1 #2202
  • fix(deps): bump @babel/runtime from 7.14.5 to 7.14.6 #2183
  • fix(deps): bump @opengovsg/formsg-sdk from 0.8.4-beta.0 to 0.9.0 #2204
  • fix(deps): bump @sentry/browser from 6.7.0 to 6.7.1 #2184
  • fix(deps): bump @sentry/browser from 6.7.1 to 6.7.2 #2228
  • fix(deps): bump @sentry/integrations from 6.7.0 to 6.7.1 #2181
  • fix(deps): bump @sentry/integrations from 6.7.1 to 6.7.2 #2227
  • fix(deps): bump aws-sdk from 2.927.0 to 2.928.0 #2182
  • fix(deps): bump aws-sdk from 2.928.0 to 2.929.0 #2191
  • fix(deps): bump aws-sdk from 2.929.0 to 2.930.0 #2203
  • fix(deps): bump aws-sdk from 2.930.0 to 2.931.0 #2214
  • fix(deps): bump libphonenumber-js from 1.9.19 to 1.9.20 #2224
  • fix(deps): bump nodemailer from 6.6.1 to 6.6.2 #2215
  • fix(deps): bump twilio from 3.63.1 to 3.64.0 #2205

karrui and others added 30 commits June 15, 2021 15:56
* feat: update landing page spcp image

* feat: minify landing page images

* feat: minify govtech img
chore: merge v5.14.0 into develop
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.927.0 to 2.928.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.927.0...v2.928.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.14.5 to 7.14.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.6/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.7.0 to 6.7.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.7.0...6.7.1)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.14.5 to 7.14.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.6/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.7.0 to 6.7.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.7.0...6.7.1)

---
updated-dependencies:
- dependency-name: "@sentry/integrations"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: merge v5.14.1 into develop
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.928.0 to 2.929.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.928.0...v2.929.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 2.7.3 to 2.7.4.
- [Release notes](https://github.com/opengovsg/mockpass/releases)
- [Commits](opengovsg/mockpass@v2.7.3...v2.7.4)

---
updated-dependencies:
- dependency-name: "@opengovsg/mockpass"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(feature-manager): remove Captcha from feature manager

* build: add test credentials for captcha

* refactor: move Captcha Joi validation into controllers
chore: merge v5.15.0 into develop
…text, long text and number fields (#2040) (#2200)

* chore: script to verify that db is consistent

* chore: remove references to customMin, customMax, Range for short text, long text and number fields in backend

* chore: remove references to customMin, customMax for short text, long text and number fields in frontend

* chore: add customMin and customMax virtuals for backward compatibility

* chore: script to unset customMin and customMax for text and number fields

* chore: remove Number casting for customVal

* chore: add todos for virtuals

* chore: correct types for virtuals

* refactor: combine TextValidationOptionsSchema

* chore: add elemMatch for field type at start of aggregation

* chore: add check for non-text/number fields

* style: lint

* chore: refine filter for update (doesn't affect outcome)

* chore: improve query syntax

* chore: rename folder to common

Co-authored-by: tshuli <[email protected]>
#2201)

* feat: add v3 API for retrieving admin form by id

* feat: remove `@routes` JSDoc line as they do not add info

and can be often wrong, and the real route is already lines away

* feat(AdminViewFormService): call v3 API to retrieve admin form

this allows us to eventually deprecate the old GET /adminform endpoints (and its ilk)

Co-authored-by: Kar Rui Lau <[email protected]>
* feat: add UEN field (#2100)

* add uen field in public frontend

* add essential uen types

* make sure uen field renders

* replace isUenValid with isUenField

* refactor: simplify isUenValid logic (#2156)

* refactor: simplify isUenValid logic

* fix: use stricter regex matching

Co-authored-by: Aniruddha Adhikary (Ani) <[email protected]>
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v1.2.0...v1.2.1)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@opengovsg/formsg-sdk](https://github.com/opengovsg/formsg-javascript-sdk) from 0.8.4-beta.0 to 0.9.0.
- [Release notes](https://github.com/opengovsg/formsg-javascript-sdk/releases)
- [Commits](https://github.com/opengovsg/formsg-javascript-sdk/commits)

---
updated-dependencies:
- dependency-name: "@opengovsg/formsg-sdk"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.63.1 to 3.64.0.
- [Release notes](https://github.com/twilio/twilio-node/releases)
- [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md)
- [Commits](twilio/twilio-node@3.63.1...3.64.0)

---
updated-dependencies:
- dependency-name: twilio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.929.0 to 2.930.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.929.0...v2.930.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.6.1 to 6.6.2.
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodemailer/nodemailer/commits)

---
updated-dependencies:
- dependency-name: nodemailer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 7.28.0 to 7.29.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.28.0...v7.29.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.930.0 to 2.931.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.930.0...v2.931.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test: fix flaky form feedback test

* docs: make comments more specific
…2158)

* feat(feature-manager): remove verified fields from feature manager

* build: add default verification key in dev
* feat(feature-manager): remove webhooks, verified content from feature manager

* build: add default signing key in dev

* docs: add comment about SQS url default
dependabot bot and others added 4 commits June 21, 2021 18:29
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.19 to 1.9.20.
- [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags)
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.9.19...v1.9.20)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.7.1 to 6.7.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.7.1...6.7.2)

---
updated-dependencies:
- dependency-name: "@sentry/integrations"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.7.1 to 6.7.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.7.1...6.7.2)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
Copy link
Contributor Author

tshuli commented Jun 22, 2021

Tests

@tshuli
feat: add and call v3 API for retrieving individual admin form

  • Access admin form. In chrome network tab, should call new /api/v3 endpoint.

feat: add UEN field

Create a UEN field and check that the following UENs are valid:

  • 01234567A
  • 012345678A
  • T01LP1234Z
  • S01LP1234Z
  • R01LP1234Z

Check that the following UENs are invalid:

  • B1234567A
  • 012345678
  • 0123456789
  • A01LP1234Z
  • S01AA1234Z
  • RS1LP1234Z
  • R010P1234Z
  • R01LPL234Z
  • R01LP12345

Submit the following UEN by API and check that the backend invalidates it:

  • R01LP12345

@tshuli
Copy link
Contributor Author

tshuli commented Jun 22, 2021

@karrui

Tests

chore: remove redundant ValidationOption object properties for short text, long text and number fields

  • Create a form with the following fields
    • Short text, with minimum 3 chars
    • Short text, with exactly 3 chars
    • Long text, with minimum 3 chars
    • Long text, with exactly 3 chars
    • Number, with minimum 3 chars
    • Number, with exactly 3 chars
  • Test that the validation works correctly and the form can be submitted
  • Edit the validation by replacing minimum with maximum. Check that the validation works correctly and form can be submitted.

@mantariksh
Backward compatibility checks

  • Repeat the above tests but using an old client for the public form user. Check that the validation works correctly and form can be submitted.
  • Repeat the above tests but using an old client for the admin. Check that the form can be modified correctly and that the modified changes persist.

@tshuli
Copy link
Contributor Author

tshuli commented Jun 22, 2021

@chowyiyin

Tests

fix: Clean-up and right-align home page statistics

feat: update landing spcp image, minify app images

feat(feature-manager): remove Captcha from feature manager

  • Create form with captcha. Check that form can be submitted.

feat(feature-manager): remove verified fields from feature manager

  • Submit an email mode form with verified email and mobile
  • Submit a storage mode form with verified email and mobile

@tshuli
Copy link
Contributor Author

tshuli commented Jun 22, 2021

@karrui

Tests

feat(feature-manager): remove webhooks, verified content

  • Create a storage mode form with verified fields. Submit and check that decrypted responses works, with the "[verified]" prefix for verified fields.
  • Create a SP-authenticated storage mode form. Submit and check that the NRIC can be decrypted.
  • Create a webhook server. Set the server to return a non-200 status the first time, then subsequently return 200. Enable retries and check that the webhook is received and decrypted correctly for both the initial attempt (which returns non-200) and the retry (which returns 200).

@tshuli tshuli changed the base branch from develop to release June 22, 2021 01:02
@tshuli tshuli merged commit c820d60 into release Jun 22, 2021
@karrui karrui deleted the release-v5.16.0 branch August 17, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants