feat(feature-manager): remove Captcha from feature manager #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
force-pushed
the
remove-fm/captcha
branch
from
317cd52 to
45e622b
Compare
karrui
approved these changes
Jun 16, 2021
src/app/modules/submission/email-submission/email-submission.routes.ts
Outdated
Show resolved
Hide resolved
karrui
approved these changes
Jun 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #1842
Solution
Removes Captcha from feature manager.
Breaking Changes
Tests
Deploy Notes
Note that the server will now fail to start in the absence of the
GOOGLE_CAPTCHAandGOOGLE_CAPTCHA_PUBLICenv vars. Default test credentials from the reCAPTCHA docs have been added todocker-compose.ymlto ensure that developers do not have to add these credentials themselves.