Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restore redundant ValidationOptions removal #2200

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

mantariksh
Copy link
Contributor

Restores changes from #2040, which were reverted in #2169.

  • Yes - this PR contains breaking changes
    • New client incompatible with old server
  • No - this PR is backwards compatible

…text, long text and number fields (#2040)

* chore: script to verify that db is consistent

* chore: remove references to customMin, customMax, Range for short text, long text and number fields in backend

* chore: remove references to customMin, customMax for short text, long text and number fields in frontend

* chore: add customMin and customMax virtuals for backward compatibility

* chore: script to unset customMin and customMax for text and number fields

* chore: remove Number casting for customVal

* chore: add todos for virtuals

* chore: correct types for virtuals

* refactor: combine TextValidationOptionsSchema

* chore: add elemMatch for field type at start of aggregation

* chore: add check for non-text/number fields

* style: lint

* chore: refine filter for update (doesn't affect outcome)

* chore: improve query syntax

* chore: rename folder to common
@mantariksh mantariksh merged commit 320caed into develop Jun 17, 2021
@tshuli tshuli mentioned this pull request Jun 22, 2021
@mantariksh mantariksh deleted the feat/restore-validation-options branch June 23, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants