Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean-up and right-align home page statistics #2219

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

frankchn
Copy link
Contributor

Problem

The current numbers on the home page is hard to read (too many digits). This right-aligns numbers and adds commas per locale settings.

Solution

Fixed the CSS and added Angular's DecimalPipe.

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

BEFORE:
before-commas

AFTER:
after-commas

Tests

Verify that the home page loads and looks as expected.

@frankchn frankchn requested review from mantariksh and r00dgirl June 21, 2021 05:02
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ran it by @pearlyong also

@mantariksh mantariksh merged commit 13528dd into develop Jun 21, 2021
@frankchn frankchn deleted the frank/format-landing-page branch June 21, 2021 07:44
@tshuli tshuli mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants