Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update landing spcp image, minify app images #2173

Merged
merged 3 commits into from
Jun 15, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jun 15, 2021

Problem

This PR update SPCP reference'd images on landing page. Also minify our images so load times for the landing page does not take so much data...
Closes #2171

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Features:

  • feat: update landing page spcp image
  • feat: minify images

Before & After Screenshots

BEFORE:

Screenshot 2021-06-15 at 3 23 34 PM

AFTER:

Screenshot 2021-06-15 at 3 18 10 PM

Tests

Manual tests

  • Landing page has updated image

@karrui karrui requested review from mantariksh and yong-jie June 15, 2021 07:24
@karrui karrui merged commit d596cdf into develop Jun 15, 2021
@karrui karrui deleted the feat/update-landing-spcp-image branch June 15, 2021 07:56
@tshuli tshuli mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update landing page image to use new Singpass/Corppass/MyInfo logos
2 participants