[Instrumentation.AWS] Update aws activitysourcename #535
Conversation
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 76.40% 76.71% +0.30%
==========================================
Files 170 170
Lines 5141 5162 +21
==========================================
+ Hits 3928 3960 +32
+ Misses 1213 1202 -11
|
| @@ -1,5 +1,11 @@ | |||
| # Changelog - OpenTelemetry.Contrib.Instrumentation.AWS | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Update the `ActivitySource` name to the assembly name: | |||
There was a problem hiding this comment.
might be a breaking change, since this package is already stable.
There was a problem hiding this comment.
might be a breaking change, since this package is already stable.
Does it make sense to remove the unreleased section?
There was a problem hiding this comment.
Can I get an update on this?
There was a problem hiding this comment.
Since this is a breaking change, you should wait for the 2.0.x release to make this change. This change shouldn't go into 1.x.x versions.
There was a problem hiding this comment.
There was a decision to remove ".Contrib" from all packages. Only AWS packages do not follow this change as mentioned in this comment
reyang
added
the
comp:instrumentation.aws
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
| @@ -21,6 +21,9 @@ namespace OpenTelemetry.Contrib.Instrumentation.AWS.Implementation | |||
| { | |||
| internal class Utils | |||
| { | |||
| internal static string ActivitySourceName = | |||
There was a problem hiding this comment.
Looking at how this played out with Instrumentation.AwsLambda so far (#534, #590 (comment), #593) I think we should either:
- Rename the whole package instead of patching the activity source name (disruptive but consistent); or
- Leave everything as-is
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #484
Changes
Use the assembly name without ".Contrib" as the ActivitySource name
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes