-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AWS] Update aws activitysourcename #535
Closed
samimusallam
wants to merge
6
commits into
open-telemetry:main
from
samimusallam:update-aws-activitysourcename
Closed
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ac3a635
Updated AWS ActivitySource name
samimusallam 29fb9f6
Moved ActivitySourceName to Utils
samimusallam b4148cc
Updated CHANGELOG.md
samimusallam 547c90f
Merge branch 'main' into update-aws-activitysourcename
utpilla 4e3d774
Merge branch 'main' into update-aws-activitysourcename
samimusallam 50601f0
Merge branch 'main' into update-aws-activitysourcename
samimusallam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,9 @@ namespace OpenTelemetry.Contrib.Instrumentation.AWS.Implementation | |
{ | ||
internal class Utils | ||
{ | ||
internal static string ActivitySourceName = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looking at how this played out with Instrumentation.AwsLambda so far (#534, #590 (comment), #593) I think we should either:
|
||
typeof(AWSTracingPipelineHandler).Assembly.GetName().Name.Replace(".Contrib", string.Empty); | ||
|
||
internal static object GetTagValue(Activity activity, string tagName) | ||
{ | ||
foreach (KeyValuePair<string, object> tag in activity.TagObjects) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a breaking change, since this package is already stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to remove the unreleased section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I get an update on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a breaking change, you should wait for the
2.0.x
release to make this change. This change shouldn't go into1.x.x
versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a decision to remove ".Contrib" from all packages. Only AWS packages do not follow this change as mentioned in this comment