-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation.AWSLambda: Rename to remove .Contrib & minor cleanups. #593
Instrumentation.AWSLambda: Rename to remove .Contrib & minor cleanups. #593
Conversation
Also move public class AWSLambdaWrapper out of implementation namespace, add version to ActivitySource.
Codecov Report
@@ Coverage Diff @@
## main #593 +/- ##
==========================================
+ Coverage 76.40% 76.70% +0.30%
==========================================
Files 170 170
Lines 5141 5161 +20
==========================================
+ Hits 3928 3959 +31
+ Misses 1213 1202 -11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to make same changes for other AWS packages?
@Kielek I'm only the owner of the AWS Lambda package, I think @srprash is responsible for AWS, and @srprash and @lupengamzn for X-Ray: opentelemetry-dotnet-contrib/.github/component_owners.yml Lines 6 to 10 in 58cfd20
|
@Oberon00 Please update the |
@utpilla Done in 46464c2, I also noticed a few other references. I left the label name in the issue template as-is. I can change that as well if you like, but I think a maintainer should rename the label in the GitHub repository settings before (see #593 (comment)). |
.github/ISSUE_TEMPLATE/comp_contrib_instrumentation_awslambda.md
Outdated
Show resolved
Hide resolved
Build failed due to unrelated problem which might be a race condition:
|
Co-authored-by: Christian Neumüller <[email protected]>
Required before the release #590.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changesCC @srprash @rypdal