-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AWSLambda] Request release of 1.1.0-beta2, reword CHANGELOG #590
[Instrumentation.AWSLambda] Request release of 1.1.0-beta2, reword CHANGELOG #590
Conversation
src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md
Outdated
Show resolved
Hide resolved
As you have a plan to bump major version, can we make the change described here #196 (comment) before the release? |
…-lambda-2 Conflicts: src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md
After #622 is merged, this is ready to be merged (though there will be conflicts in the CHANGELOG) |
This is now finally actually ready from my perspective, I know of no open points. |
@Oberon00 @rypdal I noticed that the AWSLambda project uses |
Hi, yes my idea is to only upgrade the OpenTelemetry SDK when there is a new feature we need. As the SDK is guaranteed to be backward-compatible, this should not prevent users from using any newer OpenTelemetry SDK, so I see no reason to upgrade (I'm also not blocking #580, but I don't think it's necessary to merge it before this release is made). |
@Oberon00 My apologies! I just realized after merging this PR that the package name does not follow the naming convention that we follow. Could you please rename the version from This is required because the build system sorts them alphabetically when retrieving packages, therefore, later in future |
Hi, this follows the same convention as the beta1, but since we renamed the whole package it would of course be a good opportunity to also fix this versioning. You mean the CHANGELOG heading? I think that's the only part where we specify a version (and I have to double-check the unit test, I think I regex-match somewhere there). |
Yes, that's the only thing to change. |
@open-telemetry/dotnet-contrib-maintainers: This is a request for release of version 1.1.0-beta2 of the
OpenTelemetry.Instrumentation.AWSLambda
for which I am an owner.Blocked by #593✅, #608✅, #622✅