Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation] Standardize ActivitySource names for instrumentation projects #484

Closed
utpilla opened this issue Jul 6, 2022 · 0 comments · Fixed by #534
Closed

[Instrumentation] Standardize ActivitySource names for instrumentation projects #484

utpilla opened this issue Jul 6, 2022 · 0 comments · Fixed by #534
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis

Comments

@utpilla
Copy link
Contributor

utpilla commented Jul 6, 2022

Use the assembly name as the ActivitySourceName in the instrumentation projects:

For e.g.: OpenTelemetry.Instrumentation.StackExchangeRedis

Currently, the following projects do not follow this convention:

  1. StackExchangeRedis
  2. EntityFrameworkCore
  3. AWS
  4. AWS.Lambda
@utpilla utpilla added comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis labels Jul 6, 2022
This was referenced Jul 6, 2022
Merged
Merged
This was referenced Jul 26, 2022
Merged
Closed
This was referenced Aug 9, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
Projects
None yet
Milestone
No milestone
1 participant
@utpilla