COSE envelope implementation updates #26

shizhMSFT · 2022-08-08T08:03:46Z

Tracking the merger of the cose branch into main.

Signed-off-by: Binbin Li <[email protected]>

codecov-commenter · 2022-08-08T08:05:51Z

Codecov Report

Merging #26 (c515e7a) into main (f0a5409) will decrease coverage by 6.55%.
The diff coverage is 50.25%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   70.33%   63.77%   -6.56%     
==========================================
  Files          23       27       +4     
  Lines        1591     2363     +772     
==========================================
+ Hits         1119     1507     +388     
- Misses        355      647     +292     
- Partials      117      209      +92

Impacted Files	Coverage Δ
signature/jws/signer.go	`38.23% <38.23%> (ø)`
signature/jws/jws.go	`50.00% <50.00%> (ø)`
signature/jws/utils.go	`51.13% <51.13%> (ø)`
signature/cose/cose.go	`51.38% <51.38%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

signature/signer.go

Signed-off-by: Binbin Li <[email protected]>

Refactor Verify so that it just returns the payload and signerInfo from the internal envelope. Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

* feat: implemented COSE envelope sign Signed-off-by: Patrick Zheng <[email protected]> * implemented cose envelope Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * resolve conflicts Signed-off-by: Patrick Zheng <[email protected]> * added extendedAttributes related logic Signed-off-by: Patrick Zheng <[email protected]> * updated to most current cose branch Signed-off-by: Patrick Zheng <[email protected]> * per code review Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * updates Signed-off-by: Patrick Zheng <[email protected]> * updates Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

JeyJeyGao · 2022-08-12T07:11:24Z

I will work on this task.

* refactor: add common logic to base envelope Signed-off-by: Binbin Li <[email protected]> * feat: add payload and signerInfo verification in Verify Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

* updated COSE envelope implementation per code reivew Signed-off-by: Patrick Zheng <[email protected]> * renamed to envelope under cose package Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * more clean up Signed-off-by: Patrick Zheng <[email protected]> * updated errors according to errors.go Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* feat: add error Signed-off-by: Binbin Li <[email protected]> * feat: validate key and cert while creating local signer Signed-off-by: Binbin Li <[email protected]> * refactor: refactor isKeyPair Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

signature/algorithm.go

SteveLasker · 2022-08-16T19:01:04Z

@binbin-li, @shizhMSFT, we have a set of DCO errors. Can we get these fixed up?

shizhMSFT · 2022-08-17T00:05:37Z

@binbin-li, @shizhMSFT, we have a set of DCO errors. Can we get these fixed up?

@SteveLasker This PR is just show the working progress of COSE, and will be split to multiple PRs to be reviewed and merged. Once those PRs are merged, this PR will be closed.

1. JWT sign replace custom sign 2. add SigningScheme, crit Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

* updated COSE envelope implementation per code reivew Signed-off-by: Patrick Zheng <[email protected]> * renamed to envelope under cose package Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * more clean up Signed-off-by: Patrick Zheng <[email protected]> * updated errors according to errors.go Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * update unit tests Signed-off-by: Patrick Zheng <[email protected]> * update unit tests Signed-off-by: Patrick Zheng <[email protected]> * update cose unprotected header Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* updated COSE envelope implementation per code reivew Signed-off-by: Patrick Zheng <[email protected]> * renamed to envelope under cose package Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * more clean up Signed-off-by: Patrick Zheng <[email protected]> * updated errors according to errors.go Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * update unit tests Signed-off-by: Patrick Zheng <[email protected]> * update unit tests Signed-off-by: Patrick Zheng <[email protected]> * update cose unprotected header Signed-off-by: Patrick Zheng <[email protected]> * updated COSE expiry header check Signed-off-by: Patrick Zheng <[email protected]> * updated COSE expiry header check Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

qmuntal · 2022-08-17T06:59:18Z

signature/errors.go

+
+// Error returns the formatted error message
+func (e *EnvelopeKeyRepeatedError) Error() string {
+	return fmt.Sprintf("repeated key: `%s` exists in the envelope.", e.Key)


The %q verb automagically quotes the string. Use it instead of `%s`.

@binbin-li Could you address this?

Sure, I'll do it.

Payload() returns the raw payload context instead of base64 encoded data Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]>

* doc: add signature documents Signed-off-by: Binbin Li <[email protected]> * doc: refactor comments Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

* test: add signature unit tests Signed-off-by: Binbin Li <[email protected]> * test: add tests for base envelope Signed-off-by: Binbin Li <[email protected]> * test: add more valid cases Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

* updated COSE envelope implementation per code reivew Signed-off-by: Patrick Zheng <[email protected]> * renamed to envelope under cose package Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * more clean up Signed-off-by: Patrick Zheng <[email protected]> * updated errors according to errors.go Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * update unit tests Signed-off-by: Patrick Zheng <[email protected]> * update unit tests Signed-off-by: Patrick Zheng <[email protected]> * update cose unprotected header Signed-off-by: Patrick Zheng <[email protected]> * updated COSE expiry header check Signed-off-by: Patrick Zheng <[email protected]> * updated COSE expiry header check Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updated COSE unit tests Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

… well (#48) Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated to latest go-cose Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* add jws test Signed-off-by: Junjie Gao <[email protected]> * update PR Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated to latest go-cose Signed-off-by: Patrick Zheng <[email protected]> * added COSE conformance tests Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated comments Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated to latest go-cose Signed-off-by: Patrick Zheng <[email protected]> * added COSE conformance tests Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated comments Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * added verification plugin critical headers check Signed-off-by: Patrick Zheng <[email protected]> * updated errors related code Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated to latest go-cose Signed-off-by: Patrick Zheng <[email protected]> * added COSE conformance tests Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated comments Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * added verification plugin critical headers check Signed-off-by: Patrick Zheng <[email protected]> * updated errors related code Signed-off-by: Patrick Zheng <[email protected]> * quick fix Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* fix: update jwt.Claims Signed-off-by: Junjie Gao <[email protected]> * update PR Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

…ror (#63) * added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated to latest go-cose Signed-off-by: Patrick Zheng <[email protected]> * added COSE conformance tests Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated comments Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * added verification plugin critical headers check Signed-off-by: Patrick Zheng <[email protected]> * updated errors related code Signed-off-by: Patrick Zheng <[email protected]> * quick fix Signed-off-by: Patrick Zheng <[email protected]> * renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundError Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated to latest go-cose Signed-off-by: Patrick Zheng <[email protected]> * added COSE conformance tests Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated comments Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * added verification plugin critical headers check Signed-off-by: Patrick Zheng <[email protected]> * updated errors related code Signed-off-by: Patrick Zheng <[email protected]> * quick fix Signed-off-by: Patrick Zheng <[email protected]> * renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundError Signed-off-by: Patrick Zheng <[email protected]> * quick update regarding verification plugin Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

* Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (#14) Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.4.1...v4.4.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope unit tests Signed-off-by: Patrick Zheng <[email protected]> * updating certificate chain Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for the certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated COSE envelope for certificate chain changes Signed-off-by: Patrick Zheng <[email protected]> * updated to latest go-cose Signed-off-by: Patrick Zheng <[email protected]> * added COSE conformance tests Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * updated comments Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * added verification plugin critical headers check Signed-off-by: Patrick Zheng <[email protected]> * updated errors related code Signed-off-by: Patrick Zheng <[email protected]> * quick fix Signed-off-by: Patrick Zheng <[email protected]> * renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundError Signed-off-by: Patrick Zheng <[email protected]> * quick update regarding verification plugin Signed-off-by: Patrick Zheng <[email protected]> * refactor: refactor envelope and signer to support cose (#53) Signed-off-by: Binbin Li <[email protected]> * resolve conflicts Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> * fixed broken unit tests Signed-off-by: Patrick Zheng <[email protected]> * added maps for Notation CLI cert Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Binbin Li <[email protected]>

Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

Signed-off-by: Binbin Li <[email protected]>

shizhMSFT · 2022-09-21T03:47:43Z

This PR is succeeded by #72 and #75

feat: add cose support by refining signer module (#25)

2994a36

Signed-off-by: Binbin Li <[email protected]>

shizhMSFT added the enhancement New feature or request label Aug 8, 2022

shizhMSFT added this to the RC-1 milestone Aug 8, 2022

shizhMSFT requested review from a team August 8, 2022 08:03

shizhMSFT assigned binbin-li, chloeyin, shizhMSFT and patrickzheng200 Aug 8, 2022

shizhMSFT commented Aug 8, 2022

View reviewed changes

signature/signer.go Outdated Show resolved Hide resolved

binbin-li added 2 commits August 9, 2022 13:52

refactor: refine the envelope and signer to enhance extensiblity (#27)

a45a51e

Signed-off-by: Binbin Li <[email protected]>

refactor: rename custom errors (#29)

2e99fe0

Signed-off-by: Binbin Li <[email protected]>

shizhMSFT force-pushed the cose branch from 61ca216 to 2e99fe0 Compare August 10, 2022 08:26

shizhMSFT and others added 5 commits August 10, 2022 16:26

Merge branch 'main' into cose

0553376

refactor: use internal envelope to verify (#31)

b64ffd6

Refactor Verify so that it just returns the payload and signerInfo from the internal envelope. Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

implement jws (#30)

bb1fc31

Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

feat: add missing VerifyAuthenticity (#33)

2786c0b

Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

shizhMSFT mentioned this pull request Aug 12, 2022

Confirm go-cose v1.0.0-rc.1 is ready for a 1.0.0 release #37

Closed

binbin-li and others added 3 commits August 15, 2022 17:06

qmuntal reviewed Aug 16, 2022

View reviewed changes

signature/algorithm.go Show resolved Hide resolved

JeyJeyGao and others added 3 commits August 17, 2022 09:48

feat: add jwt sign (#34)

be20e83

1. JWT sign replace custom sign 2. add SigningScheme, crit Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

qmuntal reviewed Aug 17, 2022

View reviewed changes

JeyJeyGao and others added 23 commits August 18, 2022 14:06

fix: update envelope.Payload() logic (#44)

e5da201

Payload() returns the raw payload context instead of base64 encoded data Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]>

doc: add signature documents (#39)

8aef2e4

* doc: add signature documents Signed-off-by: Binbin Li <[email protected]> * doc: refactor comments Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

added extended attribute getter for notation-go (#46)

9757c1e

* added extended attribute getter for notation-go Signed-off-by: Patrick Zheng <[email protected]> * update Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>

refactor: refactor signer and envelope to make Sign() return certs as…

563993b

… well (#48) Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

test: fix broken unit tests (#49)

c3aae6e

Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

fix: fix the certs validation in envelope.Sign() (#51)

a2fb618

Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>

refector & test: update to support new signature.Signer interface (#52)

1421844

* add jws test Signed-off-by: Junjie Gao <[email protected]> * update PR Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

add getSigningMethod (#56)

89bf762

Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

add conformance test (#57)

80a50e6

Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

fix: update jwt.Claims (#62)

1a9373f

* fix: update jwt.Claims Signed-off-by: Junjie Gao <[email protected]> * update PR Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

fix: fix unit test error code (#70)

8cdaf86

Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Junjie Gao <[email protected]>

refactor: sync changes from stage/cose branch (#74)

afc4874

Signed-off-by: Binbin Li <[email protected]>

shizhMSFT closed this Sep 21, 2022

shizhMSFT removed this from the RC-1 milestone Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COSE envelope implementation updates #26

COSE envelope implementation updates #26

shizhMSFT commented Aug 8, 2022

codecov-commenter commented Aug 8, 2022 •

edited

Loading

JeyJeyGao commented Aug 12, 2022

SteveLasker commented Aug 16, 2022 •

edited

Loading

shizhMSFT commented Aug 17, 2022

qmuntal Aug 17, 2022

shizhMSFT Aug 17, 2022

binbin-li Aug 17, 2022

shizhMSFT commented Sep 21, 2022

COSE envelope implementation updates #26

COSE envelope implementation updates #26

Conversation

shizhMSFT commented Aug 8, 2022

codecov-commenter commented Aug 8, 2022 • edited Loading

Codecov Report

JeyJeyGao commented Aug 12, 2022

SteveLasker commented Aug 16, 2022 • edited Loading

shizhMSFT commented Aug 17, 2022

qmuntal Aug 17, 2022

Choose a reason for hiding this comment

shizhMSFT Aug 17, 2022

Choose a reason for hiding this comment

binbin-li Aug 17, 2022

Choose a reason for hiding this comment

shizhMSFT commented Sep 21, 2022

codecov-commenter commented Aug 8, 2022 •

edited

Loading

SteveLasker commented Aug 16, 2022 •

edited

Loading