refactor!: refactor code to support more signature envelopes #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 70.33% 75.79% +5.46%
==========================================
Files 23 27 +4
Lines 1591 1669 +78
==========================================
+ Hits 1119 1265 +146
+ Misses 355 311 -44
+ Partials 117 93 -24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Although the DCO check fails in this PR, the DCO checks are actually passed in the sub-PRs. @gokarnm We can "set DCO to pass" before merging this PR. |
shizhMSFT
force-pushed
the
stage/cose
branch
from
56b3f7d to
ca9f3f4
Compare
Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
stage/cose
branch
from
ca9f3f4 to
65b1b6a
Compare
Signed-off-by: Binbin Li <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
changed the title
|
NOTE This PR will be merged by rebase merging. |
patrickzheng200
approved these changes
Sep 21, 2022
binbin-li
approved these changes
Sep 21, 2022
| PrivateKey() crypto.PrivateKey | ||
| } | ||
|
|
||
| // remoteSigningMethod wraps the remote signer to be a SigningMethod |
There was a problem hiding this comment.
nit: missing period in the end.
There was a problem hiding this comment.
Let's address them in other PRs.
| // Specifies the Notary v2 Signing Scheme used by the signature. | ||
| SigningScheme signature.SigningScheme `json:"io.cncf.notary.signingScheme"` | ||
|
|
||
| // The time at which the signature was generated. only valid when signing scheme is `notary.x509` |
There was a problem hiding this comment.
Let's address them in other PRs.
| // as defined at https://datatracker.ietf.org/doc/html/rfc7515#section-4.1.6. | ||
| CertChain [][]byte `json:"x5c"` | ||
|
|
||
| // SigningAgent used for signing |
There was a problem hiding this comment.
Let's address them in other PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a sum of PRs to refactor code to support more future signature envelopes like COSE.
All commits / PRs in this PR have been reviewed individually as follows.