-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename signer to signature submodule #71
Merged
shizhMSFT
merged 1 commit into
notaryproject:stage/cose
from
binbin-li:rename-signer-to-signature
Sep 9, 2022
Merged
refactor: rename signer to signature submodule #71
shizhMSFT
merged 1 commit into
notaryproject:stage/cose
from
binbin-li:rename-signer-to-signature
Sep 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Binbin Li <[email protected]>
priteshbandi
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shizhMSFT
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shizhMSFT
pushed a commit
that referenced
this pull request
Sep 13, 2022
Signed-off-by: Binbin Li <[email protected]>
binbin-li
added a commit
that referenced
this pull request
Sep 13, 2022
Signed-off-by: Binbin Li <[email protected]>
shizhMSFT
pushed a commit
that referenced
this pull request
Sep 21, 2022
Signed-off-by: Binbin Li <[email protected]>
patrickzheng200
pushed a commit
that referenced
this pull request
Sep 23, 2022
* Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (#14) Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.4.1...v4.4.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor: refactor envelope and signer to support cose (#53) Signed-off-by: Binbin Li <[email protected]> * Revert "refactor: refactor envelope and signer to support cose (#53)" (#67) This reverts commit cbea2cf. Signed-off-by: Shiwei Zhang <[email protected]> * update to go 1.18 (#66) Signed-off-by: Junjie Gao <[email protected]> * refactor: rename signer to signature submodule (#71) Signed-off-by: Binbin Li <[email protected]> * refactor: refactor envelope and signer to support cose (#73) Signed-off-by: Binbin Li <[email protected]> * feat: added COSE envelope implementation Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * resolve conflicts Signed-off-by: Patrick Zheng <[email protected]> * updated conformance test Signed-off-by: Patrick Zheng <[email protected]> * refactor: JWS for signature package (#76) Signed-off-by: Junjie Gao <[email protected]> * refactor: rename signer to signature submodule (#71) Signed-off-by: Binbin Li <[email protected]> * refactor: refactor envelope and signer to support cose (#73) Signed-off-by: Binbin Li <[email protected]> * refactor: JWS for signature package (#76) Signed-off-by: Junjie Gao <[email protected]> * Allows signing with self-signed certificate (#77) Signed-off-by: Pritesh Bandi <[email protected]> * updated conformance_test Signed-off-by: Patrick Zheng <[email protected]> * refactor: refactor comments (#78) Signed-off-by: Binbin Li <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * removed CLI related maps, they should be in notation CLI Signed-off-by: Patrick Zheng <[email protected]> * resolved conflicts Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Shiwei Zhang <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Binbin Li <[email protected]> Co-authored-by: Shiwei Zhang <[email protected]> Co-authored-by: Junjie Gao <[email protected]> Co-authored-by: Binbin Li <[email protected]> Co-authored-by: Junjie Gao <[email protected]> Co-authored-by: Pritesh Bandi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Signed-off-by: Binbin Li [email protected]