Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cose branch #69

Merged
merged 44 commits into from
Sep 7, 2022
Merged

Updated cose branch #69

merged 44 commits into from
Sep 7, 2022

Conversation

patrickzheng200
Copy link

Updated the cose branch based on Binbin's PR.

dependabot bot and others added 30 commits August 15, 2022 17:16
Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.4.1...v4.4.2)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@patrickzheng200 patrickzheng200 merged commit 25e1806 into notaryproject:cose Sep 7, 2022
@patrickzheng200 patrickzheng200 deleted the cose branch September 7, 2022 02:11
JeyJeyGao pushed a commit to JeyJeyGao/notation-core-go that referenced this pull request Sep 13, 2022
* Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (notaryproject#14)

Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.4.1...v4.4.2)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <[email protected]>

* update

Signed-off-by: Patrick Zheng <[email protected]>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <[email protected]>

* updating certificate chain

Signed-off-by: Patrick Zheng <[email protected]>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <[email protected]>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <[email protected]>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <[email protected]>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <[email protected]>

* update

Signed-off-by: Patrick Zheng <[email protected]>

* updated comments

Signed-off-by: Patrick Zheng <[email protected]>

* updated per code review

Signed-off-by: Patrick Zheng <[email protected]>

* added verification plugin critical headers check

Signed-off-by: Patrick Zheng <[email protected]>

* updated errors related code

Signed-off-by: Patrick Zheng <[email protected]>

* quick fix

Signed-off-by: Patrick Zheng <[email protected]>

* renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundError

Signed-off-by: Patrick Zheng <[email protected]>

* quick update regarding verification plugin

Signed-off-by: Patrick Zheng <[email protected]>

* refactor: refactor envelope and signer to support cose (notaryproject#53)

Signed-off-by: Binbin Li <[email protected]>

* resolve conflicts

Signed-off-by: Patrick Zheng <[email protected]>

* update

Signed-off-by: Patrick Zheng <[email protected]>

* fixed broken unit tests

Signed-off-by: Patrick Zheng <[email protected]>

* added maps for Notation CLI cert

Signed-off-by: Patrick Zheng <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Binbin Li <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Binbin Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants