Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added COSE conformance tests #55

Merged
merged 22 commits into from
Aug 26, 2022
Merged

Added COSE conformance tests #55

merged 22 commits into from
Aug 26, 2022

Conversation

patrickzheng200
Copy link

Signed-off-by: Patrick Zheng [email protected]

Two-Hearts and others added 20 commits August 22, 2022 11:37
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

Signed-off-by: Patrick Zheng <[email protected]>
@patrickzheng200 patrickzheng200 merged commit 157fd17 into notaryproject:cose Aug 26, 2022
JeyJeyGao pushed a commit to JeyJeyGao/notation-core-go that referenced this pull request Sep 13, 2022
* added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <[email protected]>

* update

Signed-off-by: Patrick Zheng <[email protected]>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <[email protected]>

* updating certificate chain

Signed-off-by: Patrick Zheng <[email protected]>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <[email protected]>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <[email protected]>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <[email protected]>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <[email protected]>

* update

Signed-off-by: Patrick Zheng <[email protected]>

* updated comments

Signed-off-by: Patrick Zheng <[email protected]>

* updated per code review

Signed-off-by: Patrick Zheng <[email protected]>

Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants