feat: refactor signature envelope to support cose #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
refactor-signature-envelope
branch
from
cc1bdda to
9774113
Compare
binbin-li
changed the title
shizhMSFT
approved these changes
Aug 8, 2022
Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
refactor-signature-envelope
branch
from
9774113 to
69d85fb
Compare
JeyJeyGao
pushed a commit
to JeyJeyGao/notation-core-go
that referenced
this pull request
Sep 13, 2022
Signed-off-by: Binbin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
signertosignaturesubmodule so that we can easily integrate COSE to the signing framework.Note: this PR only exposes the necessary intefaces and basic implementations to help engineers to work on different component parallelly.
And missing comments will be added by the following PRs.
Signed-off-by: Binbin Li [email protected]