update hund template, and add demo data #475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show_boot Add show_boot template for cisco_ios
This reverts commit ac2f256.
* XR SHOW DROPS NP ALL: Add new template
* XR SHOW DROPS NP ALL: Add new templated
CHANGES TO EXISTING PROPOSAL:
- Remove State Changes:
* There was little regex being avoided by them,
* Logic did not require state change for accurate capturing
- Move Record to happen on "Node" and "NP" lines
- Make `NP` Required to prevent capturing an empty entry on "Node" lines
- Remove `EOF` in order to capture last group now that `Record` does not happen on `-`
* XR SHOW DROPS NP ALL: Change capture groups to use lists
TEMPLATE UPDATES:
- Change variable data to be a list
* Allows for platforms with additional capacity to still work
* Changed capture groups:
`DROP_FRM_CRC_ERR_ILKN$variable` -> `ILKN_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_ILKN`
`DROP_FRM_CRC_ERR_SGMII$variable` -> `SGMII_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_SGMII`
`DROP_FRM_CRC_ERR_XAUI$variable` -> `XAUI_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_XAUI`
`DROP_FRM_FRAME_ERR_ILKN$variable` -> `ILKN_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_ILKN`
`DROP_FRM_FRAME_ERR_SGMII$variable` -> `SGMII_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_SGMII`
`DROP_FRM_FRAME_ERR_XAUI$variable` -> `XAUI_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_XAUI`
TEST FILES:
- Update parsed file to use lists with new capture group names
* Revert "XR SHOW DROPS NP ALL: Change capture groups to use lists"
This reverts commit ac2f256.
New LLDP output shows that the neighbor's hostname field might: 1) Be empty 2) Have spaces in the name Template Updates: - Add Regex matching to account for a device with an empty `System Name` field - Change `NEIGHBOR` capture group to use `.+?` to allow for spaces in the name Test Files: - Add additional raw and parsed files to test for updated info.
…orktocode#370) Newer OS versions have a separate header section for the MGMT interface than from the Ethernet interfaces. In order to account for this, the state change was removed and all matching is done under `Start`.
Fix template not accounting for neighbor name running into interface name. TEMPLATE UPDATES: - Limit `NEIGHBOR` capture group to first 20 non-space characters. - Change space capture from being required to being allowed TEST UPDATES: - Add new raw/parsed files to account for additional output
) Current Template only supports capturing OSPF Neighbor uptime in HH:MM:SS format, but there are other possible formats depending on how long the neighbor has been up. TEMPLATE UPDATE: * Change ``NEIGHBOR_UPTIME`` capture group from "(\d+:\d+:\d+)" to "(\S+)" TEST UPDATE: * Update raw and parsed files to include an uptime in format of week/day
The template does not account for an NSR state of "N/A". This updates the template to support more than one character for NSR value. TEMPLATE UPDATE: - Update ``NSR`` capture group from "(\w)" to "(\S+)" - Update Record line to include EoL marker ``\s*$$`` TEST FILES: - Update raw and parsed files to include an NSR value if "N/A"
* Test with pytest from tox instead of using Ansible * Update tests to run with python3.6 * Update netiron show monitor commands to use a single template * Remove redundant test, ``test_that_all_entries_dicts_match`` * Change to using yaml's safe_load method * Group tests together in order to load files and call TextFSM once, which creates faster test runs * Fix spacing and styling * Add failure messages to tests
networktocode#377) * Updated cisco_ios_show_lldp_neighbor_detail template with lenient accountancy for physical media capabilities
…tch naming pattern with parent folder. (networktocode#439) Updated aruba_os test files to match parent test folder names
Added OR operator and regex to type to be able to capture Fabric Exte in output for nxos_show_interface_status template
added cisco_xr_show_ip_interface_brief.template
New template: cisco_nxos_show_interfaces_switchport
New template: cisco_ios_show_interfaces_switchport
New template: paloalto_panos_show_arp_all
New template: hp_procurve_show_mac-address
New template: paloalto_panos_show_mac_all
Fixed a two recent merges that were using static spacing (cisco_ios/cisco_nxos_show_interfaces_switchport)
…rktocode#699) * Added support for Cisco IOS traceroute command This template can parse 'numeric' and 'non-numeric' versions of the output, including extra details, such as MPLS Exp bits, ASNs and MPLS labels (if available) Supports up to 10 probes per hop Captures RTT, or fault reason per probe/per hop Excessive probes per hop (11th and above) are ignored * Re-run tests against raw files * Update templates/cisco_ios_traceroute.textfsm Co-authored-by: Mikhail Yohman <[email protected]> Co-authored-by: Mikhail Yohman <[email protected]>
This template produces output similar to cisco_ios_show_ip_cef.textfsm Additional flags are no longer supported (not parsed) Type is no longer supported, this is captured as nexthop Nexthop's value is literally identical to what you get from show ip cef (brief list) Template still mandates the use of 'detail' keyword (due to index file restrictions)
… will need some more options specified, but should be good for this release, will open issue to build out .github_changelog_generator (networktocode#728)
| amps_warn_low: "" | ||
| autonegotiation: "" | ||
| dom_alarms: "" | ||
| duplex: "" |
There was a problem hiding this comment.
I'm not sure the template is working as intended. Looking at the raw output and the parsed data, it appears there is quite a bit of missing data: duplex, speed, mac_bia_add, and mac_ops_add are just a few examples.
itdependsnetworks
requested review from
jmcgill298 and
jvanderaa
as code owners
|
Addressed in #1245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
Cisco xr, show controllers hundredgige
SUMMARY
Standard updates.