Tests #402
Merged
Tests #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pytest for test framework and fix for "show ip ospf neighbor"
The function is only used once, so moving it to where it is called in order for easier comprehension.
This test is the sum of the previous tests. If the other tests pass, then this test should also pass.
The function is currently defined twice, this moves it to __init__ where both test files that use it can import the function.
* Change ``KNOWN_MISSING_TESTS`` from a list to a set * Only perform glob when current entry is not in ``KNOWN_MISSING_TESTS`` * Move ``assert`` to actual test case and still provide custom message
TEST MESSAGES: Add failure messages to tests
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Test with pytest from tox instead of using Ansible * Update tests to run with python3.6 * Update netiron show monitor commands to use a single template * Remove redundant test, ``test_that_all_entries_dicts_match`` * Change to using yaml's safe_load method * Group tests together in order to load files and call TextFSM once, which creates faster test runs * Fix spacing and styling * Add failure messages to tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to use Tox and general updates to the testing methods