XR SHOW DROPS NP ALL: Add new template #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES TO EXISTING PROPOSAL: - Remove State Changes: * There was little regex being avoided by them, * Logic did not require state change for accurate capturing - Move Record to happen on "Node" and "NP" lines - Make `NP` Required to prevent capturing an empty entry on "Node" lines - Remove `EOF` in order to capture last group now that `Record` does not happen on `-`
TEMPLATE UPDATES:
- Change variable data to be a list
* Allows for platforms with additional capacity to still work
* Changed capture groups:
`DROP_FRM_CRC_ERR_ILKN$variable` -> `ILKN_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_ILKN`
`DROP_FRM_CRC_ERR_SGMII$variable` -> `SGMII_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_SGMII`
`DROP_FRM_CRC_ERR_XAUI$variable` -> `XAUI_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_XAUI`
`DROP_FRM_FRAME_ERR_ILKN$variable` -> `ILKN_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_ILKN`
`DROP_FRM_FRAME_ERR_SGMII$variable` -> `SGMII_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_SGMII`
`DROP_FRM_FRAME_ERR_XAUI$variable` -> `XAUI_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_XAUI`
TEST FILES:
- Update parsed file to use lists with new capture group names
This reverts commit ac2f256.
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* XR SHOW DROPS NP ALL: Add new template
* XR SHOW DROPS NP ALL: Add new templated
CHANGES TO EXISTING PROPOSAL:
- Remove State Changes:
* There was little regex being avoided by them,
* Logic did not require state change for accurate capturing
- Move Record to happen on "Node" and "NP" lines
- Make `NP` Required to prevent capturing an empty entry on "Node" lines
- Remove `EOF` in order to capture last group now that `Record` does not happen on `-`
* XR SHOW DROPS NP ALL: Change capture groups to use lists
TEMPLATE UPDATES:
- Change variable data to be a list
* Allows for platforms with additional capacity to still work
* Changed capture groups:
`DROP_FRM_CRC_ERR_ILKN$variable` -> `ILKN_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_ILKN`
`DROP_FRM_CRC_ERR_SGMII$variable` -> `SGMII_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_SGMII`
`DROP_FRM_CRC_ERR_XAUI$variable` -> `XAUI_CRC_ERR_LOCATION` & `DROP_FROM_CRC_ERR_XAUI`
`DROP_FRM_FRAME_ERR_ILKN$variable` -> `ILKN_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_ILKN`
`DROP_FRM_FRAME_ERR_SGMII$variable` -> `SGMII_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_SGMII`
`DROP_FRM_FRAME_ERR_XAUI$variable` -> `XAUI_FRAME_ERR_LOCATION` & `DROP_FROM_FRAME_ERR_XAUI`
TEST FILES:
- Update parsed file to use lists with new capture group names
* Revert "XR SHOW DROPS NP ALL: Change capture groups to use lists"
This reverts commit 06876f7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_xr_show_drops_np_all
SUMMARY
Add new template