Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XR SHOW ASIC ERRORS: Add new template #353

Merged
merged 3 commits into from
Feb 23, 2019
Merged

XR SHOW ASIC ERRORS: Add new template #353

merged 3 commits into from
Feb 23, 2019

Conversation

jmcgill298
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_xr_show_asic-errors_all_location

SUMMARY

Add new template


vaneuk and others added 2 commits January 26, 2019 16:37
GENERAL UPDATES:
- Fix recording of empty captures from `ASIC` Filldown:
  * Use `Continue.Record` technique to move record on fields guarenteed for all ASICs
  * Require `INSTANCE` to prevent capturing empty data on ASIC Recording
- Change all spacing to use `\s+`
- Collapse capturing empty lines and space only lines to `\s*$$`
@jmcgill298
Copy link
Contributor Author

@vaneuk The only significant change I made was preventing an extra record from the Filldown group. Let me know if you have any issues with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants