Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lot of pull requests with small fix's, currently 73 #1095

Closed
diepes opened this issue Feb 26, 2022 · 6 comments
Closed

lot of pull requests with small fix's, currently 73 #1095

diepes opened this issue Feb 26, 2022 · 6 comments

Comments

@diepes
Copy link
Contributor

diepes commented Feb 26, 2022

Hi There,

@itdependsnetworks , @jmcgill298 , @FragmentedPacket , @jvanderaa

I see there is currently a lot of pull requests, waiting to be approved. (Currently 73)
I would like assist at getting them reviewed and approved, does anyone have the time to shadow/assist me ?

Cheers,
Pieter

@itdependsnetworks
Copy link
Contributor

Yea, that seems fair, will try and get back to you by this week

@itdependsnetworks
Copy link
Contributor

@diepes to confirm, this would be in the capacity of becoming a maintainer, presumably there would be some sort of training, then some sort of trial period. Is this something that you could commit to some minimal amount of effort. Say a 2+ hours a month as example?

@diepes
Copy link
Contributor Author

diepes commented Mar 8, 2022

@itdependsnetworks yes to help with the maintenance (pr review) for a couple of hours per month.
My thinking was that i can start by reviewing PR's commenting and approving them, even if it does not move them forward currently.
Then when one of the current Maintainers review it, get some feedback of stuff to review etc.

@diepes
Copy link
Contributor Author

diepes commented Mar 13, 2022

Looking at some of the oldes PR's >2y, should be closed/cancelled, as they have been abandoned
image

I suggest we tag and then close them after a month, anything behind more that 100 commits, and touching more than 100 files. (These are probably all pre the big poetry update)

e.g.
#418
#475

@diepes
Copy link
Contributor Author

diepes commented Apr 10, 2022

Issue: #1051 can be closed

@itdependsnetworks
Copy link
Contributor

@diepes finally getting around to fixing some things, contact me on slack if you wish to discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants