Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove indirect dependency on ocamlfind #49

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Remove indirect dependency on ocamlfind #49

merged 2 commits into from
Feb 8, 2021

Conversation

kit-ty-kate
Copy link
Contributor

No description provided.

dinosaure
dinosaure approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@dinosaure dinosaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as we keep the the compatibility with 4.03.0, I'm ok with this PR 👍.

@kit-ty-kate kit-ty-kate marked this pull request as draft February 6, 2021 21:28
@kit-ty-kate kit-ty-kate marked this pull request as ready for review February 6, 2021 21:32
@kit-ty-kate
Copy link
Contributor Author

As far as we keep the the compatibility with 4.03.0, I'm ok with this PR +1.

The base-bytes package only provides the bytes package for ocamlfind-based packages. Dune bypasses this and made the bytes library a builtin.
The Bytes module has been around since OCaml 4.02 so there is no compatibility issue there.

I also fixed CI by upgrading to ocamlformat 0.16.0 and fixing a documentation issue showing up with dune build @fmt

@dinosaure dinosaure merged commit 2c5d85d into mirage:master Feb 8, 2021
@dinosaure
Copy link
Member

Thanks, I will cut a release soon.

dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Feb 8, 2021
@dinosaure
[new release] base64 (3.5.0)
3f9656e 
CHANGES:

- Fix support for `x-compilation` (@samoht, mirage/ocaml-base64#44)
- Update to `dune.2.0` and apply `ocamlformat` (@samoht, mirage/ocaml-base64#45)
- Select `unsafe.ml` only with `dune` (@emillon, mirage/ocaml-base64#46)
- Remove indirect dependecy to `ocamlfind` (@kit-ty-kate, mirage/ocaml-base64#49)
- Hide internals of `base64` and return a `string` as the alphabet (@reynir, mirage/ocaml-base64#48)
  **breaking chnages** `Base64.alphabet` is updated and return a simple `string` now
@dinosaure dinosaure mentioned this pull request Feb 8, 2021
Merged
@kit-ty-kate kit-ty-kate deleted the patch-1 branch April 15, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinosaure dinosaure dinosaure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kit-ty-kate @dinosaure