Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base64.alphabet
leaks the internalemap
array. This PR makesBase64.alphabet
return a string instead. The following snippet shows how to breakencode |> decode
using `default_alphabet.This is obviously a breaking change since the interface is altered. As an alternative, I fixed the problem by calling
Array.copy
. The code is available in my branch hide-internals2 (with a test).I think it makes the most sense to have
Base64.alphabet
return a string.Base64.make_alphabet
takes a string, and it's annoying for the user that the alphabet characters are returned as anint array
.