Fix support for x-compilation #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying a dependency as `(dep x)` will make `dune` trying to compile `x` in the current workspace context. It already knows that `(run ./x)` needs to be run on the host context, so that's enough to make that work.
dinosaure
approved these changes
May 4, 2020
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Feb 8, 2021
CHANGES: - Fix support for `x-compilation` (@samoht, mirage/ocaml-base64#44) - Update to `dune.2.0` and apply `ocamlformat` (@samoht, mirage/ocaml-base64#45) - Select `unsafe.ml` only with `dune` (@emillon, mirage/ocaml-base64#46) - Remove indirect dependecy to `ocamlfind` (@kit-ty-kate, mirage/ocaml-base64#49) - Hide internals of `base64` and return a `string` as the alphabet (@reynir, mirage/ocaml-base64#48) **breaking chnages** `Base64.alphabet` is updated and return a simple `string` now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying a dependency as
(dep x)will makedunetrying to compilexin the current workspace context. It already knows that(run ./x)needsto be run on the host context, so that's enough to make that work.