Select unsafe.ml with just dune rules
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not necessary to use configurator to select a file depending on the OCaml version. This pattern looks like this: - a `config.exe` program (with no dependencies) checks `Sys.ocaml_version` (`scanf` will only look at the beginning of the string, so no need to parse the patch version etc) and just outputs the name of the file to copy - a rule links a file name to the output of `config.exe` - a rule copies the content of that file to `unsafe.ml`
emillon
force-pushed
the
select-dune-rules
branch
from
accde1d to
d122ecc
Compare
|
Thanks |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Feb 8, 2021
CHANGES: - Fix support for `x-compilation` (@samoht, mirage/ocaml-base64#44) - Update to `dune.2.0` and apply `ocamlformat` (@samoht, mirage/ocaml-base64#45) - Select `unsafe.ml` only with `dune` (@emillon, mirage/ocaml-base64#46) - Remove indirect dependecy to `ocamlfind` (@kit-ty-kate, mirage/ocaml-base64#49) - Hide internals of `base64` and return a `string` as the alphabet (@reynir, mirage/ocaml-base64#48) **breaking chnages** `Base64.alphabet` is updated and return a simple `string` now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was reviewing some uses of configurator and found that base64 uses it.
This is not necessary in this case so I'm sure you'll enjoy having one fewer dependency :)
In general, it is not necessary to use configurator to select a file depending on the OCaml version. This pattern looks like this:
config.exeprogram (with no dependencies) checksSys.ocaml_version(scanfwill only look at the beginning of the string, so no need to parse the patch version etc) and just outputs the name of the file to copyconfig.exeunsafe.mlLet me know what you think!