Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ocamlformat 0.14.1 #45

Merged
merged 3 commits into from
May 4, 2020
Merged

Use ocamlformat 0.14.1 #45

merged 3 commits into from
May 4, 2020

Conversation

samoht
Copy link
Member

@samoht samoht commented May 4, 2020

No description provided.

@samoht
Copy link
Member Author

samoht commented May 4, 2020

I've also enabled ocaml-ci as Travis is looooooong

@dinosaure
Copy link
Member

Forced to keep space before ;

@dinosaure
Copy link
Member

Forced to keep in at the end of the line.

Copy link
Member

@dinosaure dinosaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good now even if it's big.

@dinosaure dinosaure merged commit d04477d into mirage:master May 4, 2020
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Feb 8, 2021
CHANGES:

- Fix support for `x-compilation` (@samoht, mirage/ocaml-base64#44)
- Update to `dune.2.0` and apply `ocamlformat` (@samoht, mirage/ocaml-base64#45)
- Select `unsafe.ml` only with `dune` (@emillon, mirage/ocaml-base64#46)
- Remove indirect dependecy to `ocamlfind` (@kit-ty-kate, mirage/ocaml-base64#49)
- Hide internals of `base64` and return a `string` as the alphabet (@reynir, mirage/ocaml-base64#48)
  **breaking chnages** `Base64.alphabet` is updated and return a simple `string` now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants