-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🔃 [Magento Community Engineering] Community Contributions - 2.4-develop
Accepted Community Pull Requests: - #26129: Refactor / Cleanup: `use` section does not need leading backslash (by @lbajsarowicz) - #26131: Reduce sleep time for Unit Test of Consumer to 0 seconds (by @lbajsarowicz) - #26125: [WishlistGraphQL] Covering the CustomerWishlistResolver (by @lbajsarowicz) - #26126: [WeeeGraphQl] Covering the FixedProductTax (by @lbajsarowicz) - #26033: Normalize new line symbols in Product Text Option (type=area) (by @Leone) - #25915: Tests for: #24907, #25051, #25149, #24973, #25666. (by @p-bystritsky) - #25853: Tests for: #25585, #25248, #25058. (by @p-bystritsky) - #25315: Error in vendor/magento/module-shipping/Model/Config/Source/Allmethod� (by @mrodespin) - #25838: [FIXES] #25674: Elasticsearch version selections in admin are overly � (by @mautz-et-tong) Fixed GitHub Issues: - #25974: Amount of characters on a 'Area' Customizable Option counted differently on backend/frontend (reported by @hans-vereyken) has been fixed in #26033 by @Leone in 2.4-develop branch Related commits: 1. 284e3ed 2. 2ae6838 3. d2a4865 4. 6e68a47 - #13136: Error in vendor/magento/module-shipping/Model/Config/Source/Allmethods.php - public function toOptionArray (reported by @Tantuss) has been fixed in #25315 by @mrodespin in 2.4-develop branch Related commits: 1. 529c46f 2. c4a3c00 3. fd7633b - #25674: Elasticsearch version selections in admin are overly broad (reported by @dobooth) has been fixed in #25838 by @mautz-et-tong in 2.4-develop branch Related commits: 1. cf1b084 2. 37cf56d
- Loading branch information
Showing
224 changed files
with
1,186 additions
and
230 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
app/code/Magento/Catalog/Test/Mftf/Test/ProductAttributeWithoutValueInCompareListTest.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd"> | ||
<test name="ProductAttributeWithoutValueInCompareListTest"> | ||
<annotations> | ||
<features value="Catalog"/> | ||
<title value="Product attribute without value in compare list test"/> | ||
<description | ||
value="The product attribute that has no value should output 'N/A' on the product comparison page."/> | ||
<severity value="MINOR"/> | ||
<group value="Catalog"/> | ||
</annotations> | ||
<before> | ||
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/> | ||
<createData entity="textProductAttribute" stepKey="createProductAttribute"/> | ||
<createData entity="CatalogAttributeSet" stepKey="createAttributeSet"/> | ||
<amOnPage url="{{AdminProductAttributeSetEditPage.url}}/$$createAttributeSet.attribute_set_id$$/" | ||
stepKey="onAttributeSetEdit"/> | ||
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup"> | ||
<argument name="group" value="Product Details"/> | ||
<argument name="attribute" value="$$createProductAttribute.attribute_code$$"/> | ||
</actionGroup> | ||
<actionGroup ref="SaveAttributeSetActionGroup" stepKey="SaveAttributeSet"/> | ||
<createData entity="_defaultCategory" stepKey="createCategory"/> | ||
<createData entity="_defaultProduct" stepKey="createProductDefault"> | ||
<requiredEntity createDataKey="createCategory"/> | ||
</createData> | ||
<createData entity="SimpleProductWithCustomAttributeSet" stepKey="createProductCustom"> | ||
<requiredEntity createDataKey="createCategory"/> | ||
<requiredEntity createDataKey="createAttributeSet"/> | ||
</createData> | ||
</before> | ||
<after> | ||
<deleteData createDataKey="createProductDefault" stepKey="deleteProductDefault"/> | ||
<deleteData createDataKey="createProductCustom" stepKey="deleteProductCustom"/> | ||
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/> | ||
<deleteData createDataKey="createAttributeSet" stepKey="deleteAttributeSet"/> | ||
<deleteData createDataKey="createProductAttribute" stepKey="deleteProductAttribute"/> | ||
<actionGroup ref="logout" stepKey="logout"/> | ||
</after> | ||
<!--Open product page--> | ||
<amOnPage url="{{StorefrontProductPage.url($$createProductDefault.name$$)}}" stepKey="goToProductDefaultPage"/> | ||
<waitForPageLoad stepKey="waitForProductPage"/> | ||
<!--Click on 'Add to Compare' link--> | ||
<actionGroup ref="StorefrontAddProductToCompareActionGroup" stepKey="clickOnAddToCompare"> | ||
<argument name="productVar" value="$$createProductDefault$$"/> | ||
</actionGroup> | ||
<!--See product in the comparison list--> | ||
<actionGroup ref="SeeProductInComparisonListActionGroup" stepKey="seeProductDefaultInComparisonListActionGroup"> | ||
<argument name="productVar" value="$$createProductDefault$$"/> | ||
</actionGroup> | ||
<!--Open product with custom attribute page--> | ||
<amOnPage url="{{StorefrontProductPage.url($$createProductCustom.name$$)}}" stepKey="goToProductCustomPage"/> | ||
<waitForPageLoad stepKey="waitForProductCustomPage"/> | ||
<!--Click on 'Add to Compare' link--> | ||
<actionGroup ref="StorefrontAddProductToCompareActionGroup" stepKey="clickOnAddToCompareCustom"> | ||
<argument name="productVar" value="$$createProductCustom$$"/> | ||
</actionGroup> | ||
<!--See product with custom attribute in the comparison list--> | ||
<actionGroup ref="SeeProductInComparisonListActionGroup" stepKey="seeProductCustomInComparisonListActionGroup"> | ||
<argument name="productVar" value="$$createProductCustom$$"/> | ||
</actionGroup> | ||
<!--See attribute default value in the comparison list--> | ||
<see userInput="$createProductAttribute.defaultValue$" | ||
selector="{{StorefrontProductCompareMainSection.ProductAttributeByCodeAndProductName(ProductAttributeFrontendLabel.label, $createProductCustom.name$)}}" | ||
stepKey="assertAttributeValueForProductCustom"/> | ||
<!--See N/A if attribute has no value in the comparison list--> | ||
<see userInput="N/A" | ||
selector="{{StorefrontProductCompareMainSection.ProductAttributeByCodeAndProductName(ProductAttributeFrontendLabel.label, $createProductDefault.name$)}}" | ||
stepKey="assertNAForProductDefault"/> | ||
</test> | ||
</tests> |
61 changes: 61 additions & 0 deletions
61
app/code/Magento/Catalog/Test/Mftf/Test/StorefrontFotoramaArrowsTest.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd"> | ||
<test name="AdminAddDefaultImageSimpleProductTest"> | ||
<annotations> | ||
<features value="Catalog"/> | ||
<title value="Storefront Fotorama arrows test"/> | ||
<description value="Check arrows next to the thumbs are not visible than there is room for all pictures."/> | ||
<severity value="MINOR"/> | ||
<group value="Catalog"/> | ||
</annotations> | ||
<before> | ||
<createData entity="_defaultCategory" stepKey="createCategory"/> | ||
<createData entity="_defaultProduct" stepKey="createProduct"> | ||
<requiredEntity createDataKey="createCategory"/> | ||
</createData> | ||
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/> | ||
</before> | ||
<after> | ||
<actionGroup ref="logout" stepKey="logout"/> | ||
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/> | ||
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/> | ||
</after> | ||
|
||
<!-- Open Product for edit --> | ||
<actionGroup ref="SearchForProductOnBackendActionGroup" stepKey="findCreatedProductInGrid"> | ||
<argument name="product" value="$$createProduct$$"/> | ||
</actionGroup> | ||
<actionGroup ref="OpenEditProductOnBackendActionGroup" stepKey="goToEditProductPage"> | ||
<argument name="product" value="$$createProduct$$"/> | ||
</actionGroup> | ||
|
||
<!-- Add images to product --> | ||
<actionGroup ref="AddProductImageActionGroup" stepKey="addFirstImageToProduct"> | ||
<argument name="image" value="MagentoLogo"/> | ||
</actionGroup> | ||
<actionGroup ref="AddProductImageActionGroup" stepKey="addSecondImageToProduct"> | ||
<argument name="image" value="ProductImage"/> | ||
</actionGroup> | ||
<actionGroup ref="AddProductImageActionGroup" stepKey="addThirdImageToProduct"> | ||
<argument name="image" value="TestImageNew"/> | ||
</actionGroup> | ||
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveSimpleProduct"/> | ||
|
||
<!-- Assert product in storefront product page --> | ||
<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openCreatedProductPage"> | ||
<argument name="productUrl" value="$$createProduct.name$$"/> | ||
</actionGroup> | ||
|
||
<!-- Assert Fotorama arrows aren't visible --> | ||
<dontSeeElement selector="{{StorefrontProductMediaSection.fotoramaPrevButton}}" stepKey="dontSeePrevButton"/> | ||
<dontSeeElement selector="{{StorefrontProductMediaSection.fotoramaNextButton}}" stepKey="dontSeeNextButton"/> | ||
</test> | ||
</tests> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.