-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXES] #25674: Elasticsearch version selections in admin are overly … #25838
[FIXES] #25674: Elasticsearch version selections in admin are overly … #25838
Conversation
…overly broad. This removes the X.0+ notation and replaces it with X.x notation
Hi @mautz-et-tong. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you |
Hi @davidverholen, here is your new Magento instance. |
Hi @davidverholen, thank you for the review.
|
✔️ QA Passed Note: @mautz-et-tong You can also create a PR on the magento/merchdocs repository to correct the X.0+ notation for the user documentation. Thanks! |
@mautz-et-tong, thank you for the contribution. Please, cover changes by MFTF tests. |
@engcom-Foxtrot tell me please: what exactly should I cover with MFTF? Have you seen the PR? I switched comments and labels and stuff like that. Are there test failing now, because the comments and labels were checked? Or should I add tests to tests if the labels are now exactly in the new notation? I really don't know what do do here... |
@mautz-et-tong Could you resolve merge conflicts? |
Hi @davidverholen, thank you for the review. |
✔️ QA Passed |
Hi @mautz-et-tong, thank you for your contribution! |
…broad.
Description (*)
This removes the X.0+ notation and replaces it with X.x notation
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)