Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / Cleanup: use section does not need leading backslash #26129

Merged

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

use section does not actually need \ at the beginning of the classpath (leading backslash)

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2019

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Strix partners-contribution Pull Request is created by Magento Partner labels Dec 19, 2019
@dmytro-ch dmytro-ch self-assigned this Dec 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6504 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Charlie engcom-Charlie self-assigned this Dec 19, 2019
@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 19, 2019
@engcom-Charlie
Copy link
Contributor

✔️ QA Passed

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Dec 19, 2019

Wasn't it enforced by static tests? If no - It's good idea to add it
/CC @lenaorobei

@engcom-Golf engcom-Golf self-assigned this Dec 19, 2019
@ihor-sviziev
Copy link
Contributor

I just reported issue for coding standard magento/magento-coding-standard#165

@magento-engcom-team magento-engcom-team merged commit 2179e73 into magento:2.4-develop Dec 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 29, 2019

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@orlangur
Copy link
Contributor

@ihor-sviziev @lenaorobei such test should have been elaborated in the first place and only then changes merged. There is existing fix for php-cs-fixer doing this, I suppose it was used by PR author.

@lbajsarowicz
Copy link
Contributor Author

Actually, I haven't used php-cs-fixer but I already spoke to @lenaorobei that I'm going to send her form time to time tool + config to get rid of the most common issues of code style that do not affect how code works.

By this I mean - removing leading backslashes, incorrect annotations etc.

@orlangur
Copy link
Contributor

@lbajsarowicz send where? Changes just applied and merged from time to time?

@lbajsarowicz
Copy link
Contributor Author

@orlangur I want - from time to time - review what changes can be applied (the ones that we have already covered with automated static checks), and fix them automatically for whole Magento, not as a contribution.

@orlangur
Copy link
Contributor

I see, then it sounds good as may be applied to ce/ee/b2b codebase all at once.

The right thing is actually forbid any coding standard violations and apply necessary changes together with any rule addition. I promoted such approach from the very beginning but wasn't heard and as a result poor processes were established and this is still not fixed.

@lbajsarowicz
Copy link
Contributor Author

@orlangur So, let's do that together : ) I believe that now, before 2.4 that would be a little bit easier

@orlangur
Copy link
Contributor

Okiz. Let me aggregate my thoughts and older notes during this longer weekend and then I'll reach you out. @coderimus is in too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: multiple Partner: Strix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants