-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor / Cleanup: use
section does not need leading backslash
#26129
Refactor / Cleanup: use
section does not need leading backslash
#26129
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
f33cf7b
to
2179e73
Compare
Hi @dmytro-ch, thank you for the review.
|
✔️ QA Passed |
Wasn't it enforced by static tests? If no - It's good idea to add it |
I just reported issue for coding standard magento/magento-coding-standard#165 |
Hi @lbajsarowicz, thank you for your contribution! |
@ihor-sviziev @lenaorobei such test should have been elaborated in the first place and only then changes merged. There is existing fix for |
Actually, I haven't used By this I mean - removing leading backslashes, incorrect annotations etc. |
@lbajsarowicz send where? Changes just applied and merged from time to time? |
@orlangur I want - from time to time - review what changes can be applied (the ones that we have already covered with automated static checks), and fix them automatically for whole Magento, not as a contribution. |
I see, then it sounds good as may be applied to ce/ee/b2b codebase all at once. The right thing is actually forbid any coding standard violations and apply necessary changes together with any rule addition. I promoted such approach from the very beginning but wasn't heard and as a result poor processes were established and this is still not fixed. |
@orlangur So, let's do that together : ) I believe that now, before 2.4 that would be a little bit easier |
Okiz. Let me aggregate my thoughts and older notes during this longer weekend and then I'll reach you out. @coderimus is in too. |
Description (*)
use
section does not actually need\
at the beginning of the classpath (leading backslash)Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Questions or comments
N/A
Contribution checklist (*)