-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers issue25057 #25058
Conversation
… empty instead of "----" in Newsletter Subscribers issue25057
Hi @edenduong. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@@ -91,7 +91,6 @@ | |||
<arguments> | |||
<argument name="header" xsi:type="string" translate="true">Customer First Name</argument> | |||
<argument name="index" xsi:type="string">firstname</argument> | |||
<argument name="default" xsi:type="string">----</argument> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edenduong Do you think removing ----
and keeping this argument tag as it is without value would also solve the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kalpmehta : Yes, It can solve this issue. But I think it would be better if we remove it.
Thank you .
Hi @kalpmehta, thank you for the review. |
✔️ QA Passed |
…hould display empty instead of "----" in Newsletter Subscribers issue25057 #25058
Hi @edenduong, thank you for your contribution! |
Covered in the scope of #25853 |
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
"Customer First Name" and "Customer Last Name" should display empty instead of "----"
Expected result
1."Customer First Name" and "Customer Last Name" should display empty
Questions or comments
Contribution checklist (*)