Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers issue25057 #25058

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers  #25057: "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers

Fixed Issues (if relevant)

  1. "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers  #25057: "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers

Manual testing scenarios (*)

  1. Go to frontend, subscribe the newsletter with Guest
  2. Go to backend
  3. Marketing->Newsletter Subscribers
  4. Check the grid

"Customer First Name" and "Customer Last Name" should display empty instead of "----"

Expected result

1."Customer First Name" and "Customer Last Name" should display empty

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… empty instead of "----" in Newsletter Subscribers issue25057
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@@ -91,7 +91,6 @@
<arguments>
<argument name="header" xsi:type="string" translate="true">Customer First Name</argument>
<argument name="index" xsi:type="string">firstname</argument>
<argument name="default" xsi:type="string">----</argument>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edenduong Do you think removing ---- and keeping this argument tag as it is without value would also solve the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kalpmehta : Yes, It can solve this issue. But I think it would be better if we remove it.
Thank you .

@kalpmehta kalpmehta mentioned this pull request Oct 21, 2019
4 tasks
@kalpmehta kalpmehta added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Oct 21, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-6144 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 22, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 23, 2019
…hould display empty instead of "----" in Newsletter Subscribers issue25057 #25058
@magento-engcom-team magento-engcom-team merged commit 23bf2f8 into magento:2.3-develop Oct 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 23, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this pull request Nov 28, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 2, 2019
@VladimirZaets
Copy link
Contributor

Covered in the scope of #25853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants